Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cell editor and execution count rendering for large code cell #209154

Closed
rebornix opened this issue Mar 29, 2024 · 3 comments
Closed

Improve cell editor and execution count rendering for large code cell #209154

rebornix opened this issue Mar 29, 2024 · 3 comments
Assignees
@rebornix
Labels
feature-request Request for new features or functionality notebook notebook-execution Issues related to running cells in a notebook on-testplan papercut 🩸 A particularly annoying issue impacting someone on the team
Milestone
August 2024

Comments

@rebornix
Copy link
Member

  • have a cell which can be larger than the viewport
  • scroll its cell status bar out of the viewport
  • when the cell runs fast, I can't tell if it runs or not as both the execution count and the cell status bar are invisible

image
@rebornix rebornix added the papercut 🩸 A particularly annoying issue impacting someone on the team label Mar 29, 2024
@rebornix rebornix self-assigned this Mar 29, 2024
@rebornix rebornix mentioned this issue Jun 12, 2024
Open
14 tasks
@rebornix
Copy link
Member Author

When we are scrolling down, we will make the execution button sticky to ensure it's always visible to users. Maybe we can do the same for the execution count. We could also have some affordance for the execution count for indicating its state (succeed/fail).

@rebornix rebornix added this to the July 2024 milestone Jun 23, 2024
@rebornix rebornix added notebook notebook-execution Issues related to running cells in a notebook labels Jun 23, 2024
@rebornix
Copy link
Member Author

Similar issue #215487

@kieferrm kieferrm mentioned this issue Jul 8, 2024
Closed
48 tasks
@rebornix rebornix modified the milestones: July 2024, August 2024 Jul 23, 2024
@rebornix rebornix added the feature-request Request for new features or functionality label Jul 30, 2024
@kieferrm kieferrm mentioned this issue Aug 4, 2024
Closed
56 tasks
rebornix added a commit that referenced this issue Aug 6, 2024
@rebornix
Re #209154. Make execution count sticky.
a957c54
rebornix added a commit that referenced this issue Aug 6, 2024
@rebornix
Re #209154. Make execution count sticky. (#224905)
6288e5d
@rebornix rebornix changed the title No visual indicator of cell execution success when a code cell is large Improve cell editor and execution count rendering for large code cell Aug 6, 2024
@rebornix
Copy link
Member Author

rebornix commented Aug 6, 2024 •
edited
Loading

Another optimization we could explore is to render the code cell editor only at the maximum height of the viewport.

rendering a cell with 200 lines of code

image

rendering the same cell at the max height of the viewport

image

rebornix added a commit that referenced this issue Aug 9, 2024
@rebornix
Re #209154. Render code editor at maximum height of the viewport
03fc9ac
rebornix added a commit that referenced this issue Aug 9, 2024
@rebornix
Merge pull request #225203 from microsoft/rebornix/universal-anglerfish
da5d462 
Re #209154. Render code editor at maximum height of the viewport
@rebornix rebornix mentioned this issue Aug 27, 2024
Closed
1 task
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
feature-request Request for new features or functionality notebook notebook-execution Issues related to running cells in a notebook on-testplan papercut 🩸 A particularly annoying issue impacting someone on the team
Projects
None yet
Milestone
August 2024
Development

No branches or pull requests
1 participant
@rebornix