chore: update to electron 29 #209818
Merged
chore: update to electron 29 #209818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
electron-29.x.y
branch
2 times, most recently
from
ec41e43 to
aab3d14
Compare
|
Depends on electron/electron#41830 |
deepak1556
force-pushed
the
electron-29.x.y
branch
5 times, most recently
from
d490508 to
0d30cf1
Compare
Closed
deepak1556
force-pushed
the
electron-29.x.y
branch
from
0d30cf1 to
54dc529
Compare
deepak1556
force-pushed
the
electron-29.x.y
branch
3 times, most recently
from
dd35000 to
2d106a1
Compare
This was referenced May 3, 2024
deepak1556
force-pushed
the
electron-29.x.y
branch
5 times, most recently
from
c759471 to
57f061e
Compare
$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
Found 2 errors in 2 files.
Errors Files
1 node_modules/@types/chokidar/index.d.ts:21
1 node_modules/chokidar/types/index.d.ts:8
Refs paulmillr/chokidar@a0f9e09
deepak1556
force-pushed
the
electron-29.x.y
branch
from
57f061e to
20def5a
Compare
deepak1556
force-pushed
the
electron-29.x.y
branch
from
57f5d83 to
81606f6
Compare
bpasero
previously approved these changes
May 10, 2024
bpasero
approved these changes
May 10, 2024
|
I think this contradicts the versioning here in the contributing docs: https://github.com/microsoft/vscode/wiki/How-to-Contribute |
|
Thanks! updated the wiki. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210467