-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: update to electron 29 (#209818)
* chore: update [email protected] * chore: update typings to 20.x * chore: bump [email protected] * ci: fix crash in compiling extensions-ci * chore: disable .d.ts check for build/ $ ../node_modules/.bin/tsc -p tsconfig.build.json node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'. Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref 21 export class FSWatcher extends EventEmitter implements fs.FSWatcher { ~~~~~~~~~ node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'. Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref 8 export class FSWatcher extends EventEmitter implements fs.FSWatcher { ~~~~~~~~~ Found 2 errors in 2 files. Errors Files 1 node_modules/@types/chokidar/index.d.ts:21 1 node_modules/chokidar/types/index.d.ts:8 Refs paulmillr/chokidar@a0f9e09 * chore: update core types * temp: fix layer validation * chore: update nodejs checksums * ci: use latest v20 LTS for missing node-gyp Refs npm/cli@eacec5f * ci: define LIBCPP_HARDENING_MODE * ci: fix crash in vscode-web-min-ci * chore: update rpm deps-list * chore: bump [email protected] * chore: bump [email protected] * chore: bump [email protected] * chore: update rpm deps-list for x86_64 * ci: disable io_uring UV backend on linux * ci: disable io_uring backend for oss as well * chore: update typings to 20.x * ci: add TODO for io_uring workaround * chore: bump distro * chore: update preinstall node version checks * chore: update @types/gulp Refs #212442 * ci: disable io_uring in more test suites
- Loading branch information
1 parent
c5e287e
commit 5216c04
Showing
101 changed files
with
797 additions
and
361 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 18.19.0 | ||
| 20.12.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| disturl "https://electronjs.org/headers" | ||
| target "28.2.8" | ||
| ms_build_id "27744544" | ||
| target "29.3.1" | ||
| ms_build_id "9464424" | ||
| runtime "electron" | ||
| build_from_source "true" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,8 +78,6 @@ steps: | |
|
|
||
| - script: | | ||
| set -e | ||
| export npm_config_arch=$(VSCODE_ARCH) | ||
| npm i -g [email protected] | ||
| python3 -m pip install setuptools | ||
| for i in {1..5}; do # try 5 times | ||
|
|
@@ -91,6 +89,7 @@ steps: | |
| echo "Yarn failed $i, trying again..." | ||
| done | ||
| env: | ||
| npm_config_arch: $(VSCODE_ARCH) | ||
| ELECTRON_SKIP_BINARY_DOWNLOAD: 1 | ||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
| GITHUB_TOKEN: "$(github-distro-mixin-password)" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,16 +93,10 @@ steps: | |
| . build/azure-pipelines/win32/exec.ps1 | ||
| . build/azure-pipelines/win32/retry.ps1 | ||
| $ErrorActionPreference = "Stop" | ||
| # TODO: remove custom node-gyp when updating to Node v20, | ||
| # refs https://github.com/npm/cli/releases/tag/v10.2.3 which is available with Node >= 20.10.0 | ||
| $nodeGypDir = "$(Agent.TempDirectory)/custom-packages" | ||
| mkdir "$nodeGypDir" | ||
| npm install [email protected] -g --prefix "$nodeGypDir" | ||
| $env:npm_config_node_gyp = "${nodeGypDir}/node_modules/node-gyp/bin/node-gyp.js" | ||
| $env:npm_config_arch = "$(VSCODE_ARCH)" | ||
| $env:CHILD_CONCURRENCY="1" | ||
| retry { exec { yarn --frozen-lockfile --check-files } } | ||
| env: | ||
| npm_config_arch: $(VSCODE_ARCH) | ||
| CHILD_CONCURRENCY: 1 | ||
| ELECTRON_SKIP_BINARY_DOWNLOAD: 1 | ||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
| GITHUB_TOKEN: "$(github-distro-mixin-password)" | ||
|
|
||
Oops, something went wrong.