Remove dispose from IContextKeyService
#176673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
commented
Mar 9, 2023
connor4312
previously approved these changes
Mar 9, 2023
joyceerhl
changed the title
dispose from IContextKeyService
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #176659 (comment)
It's unclear whether context key services created via
createOverlayneed to be disposed without reading the impl and seeing thatdisposeis a noop, this PR attempts to clarify that by updatingContextKeyServices to not requiredispose. SinceScopedContextKeyServices are often a drop in replacement but do need to be disposed by the caller, this also introduces a new interfaceIScopedContextKeyService. Finally, I updated a few places where overlay context key services were being unnecessarily disposed.