Add editorLineNumber context key
#176659
Merged
Add editorLineNumber context key
#176659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
approved these changes
Mar 9, 2023
connor4312
requested changes
Mar 9, 2023
| return; | ||
| } | ||
|
|
||
| const anchor = { x: e.event.posx, y: e.event.posy }; | ||
| const lineNumber = e.target.position.lineNumber; | ||
|
|
||
| const contextKeyService = this.contextKeyService.createOverlay([['editorLineNumber', lineNumber]]); |
There was a problem hiding this comment.
I think you need to dispose this after you close the menu.
There was a problem hiding this comment.
I was wondering about that, but every other consumer of createOverlay doesn't dispose it.
There was a problem hiding this comment.
Maybe worth an issue for the other cases then--and I'll update this PR to dispose it.
There was a problem hiding this comment.
It looks like dispose no-ops on it, so probably okay.
There was a problem hiding this comment.
I think the better thing would splitting out the IContextKeyService interface so that .dispose() doesn't have to be defined on something that doesn't need to be disposed.
connor4312
approved these changes
Mar 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #175945