Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsconfig.json lightbulb hint #15213

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Nov 8, 2016

Issue #15205

Bug
Typescript now infers the js project if no jsconfig.json is found. This means that the light bulb hint about creating a jsconfig.json file is not required.

Fix
Remove the jsconfig.json light bulb logic.

closes #15205

Issue microsoft#15205

**Bug**
Typescript now infers projects if no jsconfig.json is found. This means that the hint about creating a `jsconfig.json` file is not required.

**Fix**
Remove the `jsconfig.json` hinting logic.
@mention-bot
Copy link

@mjbvz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken to be a potential reviewer.

@jrieken jrieken self-assigned this Nov 9, 2016
@jrieken jrieken added this to the November 2016 milestone Nov 9, 2016
@jrieken
Copy link
Member

jrieken commented Nov 9, 2016

LGTM. Thanks. @joaomoreno 👯‍♂️

@jrieken jrieken merged commit 3561a5b into microsoft:master Nov 9, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove jsconfig.json light bulb
4 participants