Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jsconfig.json light bulb #15205

Closed
mjbvz opened this issue Nov 8, 2016 · 0 comments · Fixed by #15213
Closed

Remove jsconfig.json light bulb #15205

mjbvz opened this issue Nov 8, 2016 · 0 comments · Fixed by #15213
Assignees
@mjbvz
Labels
plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2016

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 8, 2016

Remove the hint about creating a that displays in JavaScript projects without a jsconfig.json file present. I believe that TypeScript will now infer projects if no jsconfig.json file is found.
@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Nov 8, 2016
@mjbvz mjbvz added this to the November 2016 milestone Nov 8, 2016
@mjbvz mjbvz self-assigned this Nov 8, 2016
@kieferrm kieferrm mentioned this issue Nov 8, 2016
Closed
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 8, 2016
@mjbvz
Remove jsconfig.json lightbulb hint
a523c2d 
Issue microsoft#15205

**Bug**
Typescript now infers projects if no jsconfig.json is found. This means that the hint about creating a `jsconfig.json` file is not required.

**Fix**
Remove the `jsconfig.json` hinting logic.
@mjbvz mjbvz mentioned this issue Nov 8, 2016
Merged
@mjbvz mjbvz mentioned this issue Nov 10, 2016
Closed
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Dec 5, 2016
@jrieken jrieken added the verified Verification succeeded label Dec 7, 2016
@egamma egamma mentioned this issue Dec 20, 2016
Closed
56 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

Successfully merging a pull request may close this issue.

Remove jsconfig.json lightbulb hint mjbvz/vscode
2 participants
@jrieken @mjbvz