Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workbench.editor.alwaysOpenInActiveGroupFromQuickOpen setting #134525

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mkcode
Copy link

@mkcode mkcode commented Oct 6, 2021

This PR is a follow up from #134478.
It is also tangentially related to #94705 where there has been lots of discussion.

Rather than overriding the workbench.editor.revealIfOpen setting and changing the default behavior, a new setting is introduced in order to make this an opt in behavior.

When enabling the workbench.editor.alwaysOpenInActiveGroupFromQuickOpen setting, opening editors from Quick Open will always open in the active group.

This shows the change in behavior with the setting disabled and then enabled:

Code - OSS-2021-10-06 at 14 49 25

This settings controls whether editors opened from Quick Open will
always open in the currently active editor group. Similar to setting the
'revealIfOpened' setting to false, enabling this setting will open
multiple copies of an editor in different editor group.
@ghost
Copy link

ghost commented Oct 6, 2021

CLA assistant check
All CLA requirements met.

@aguynamedben
Copy link

The PR below is a spiritual success to this PR that we're hoping will actually get merged:

@jonathanjameswatson PR that adds a revealIfOpenInActiveGroup option. There's a video demo. #205442

Please also +1 in this issue: #204942

The option allows users to automatically recall (move) an open Editor into the active Editor Group. This allows user accustomed to Emacs or vi/vim/neovim buffer-centric workflows to use Quick Find as a buffer switcher without undesirable opening files once-per-Editor Group. It basically allows you to not really worry about which file (Editor) is in which Editor Group at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants