Respect revealIfOpen setting when opening editors with Quick Open #134478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where there is inconsistent behavior between opening file and editors when using Quick Open with respecting the
workbench.editor.revealIfOpen
setting.Before this PR:
workbench.editor.revealIfOpen
setting.workbench.editor.revealIfOpen
setting.After this PR:
workbench.editor.revealIfOpen
setting.workbench.editor.revealIfOpen
settingThis PR is tangentially related to #94705 where there has been lots of discussion.
I made an alternative implementation which introduces a unique setting
workbench.editor.alwaysOpenInActiveGroupFromQuickOpen
here: 02d4d73 But IMO, it is more clean to use the existing setting to create consistent behavior in this case, rather than introducing a new more granular setting.