Add colorized bracket highlighting colours

[TabithaLarkin]

This PR fixes #132493

As suggested in this comment by @hediet.

This shows an preview of what these colours would look like (generated from adding these settings to my local settings.json file.

edit by @hediet:

With default colors:

Without bracket pair colorization:

[hediet]

Thanks! Can you post a before/after screenshot of the same code region, so that it becomes very clear what the difference is?

[TabithaLarkin]

Ah, I've already added those screenshots to the issue that I raised, with the bracket colorization off and on too.

[hediet]

@roblourens what do you think (I think it is your theme)?

[roblourens]

Not me :)

[roblourens]

I don't think that individual themes have owners. You could run it by @misolori if you want another opinion. Looks fine to me though.

[hediet]

@misolori What do you think?

[miguelsolorio]

Here's a snapshot of the theme colors + bracket colors with the original vs the proposed colors:

I'd probably keep the bracket colors closer to the original so this is what I would suggest:

		"editorBracketHighlight.foreground1": "#b58800",
		"editorBracketHighlight.foreground2": "#d33682",
		"editorBracketHighlight.foreground3": "#0B75BF",

Before

After

[TabithaLarkin]

The reason I selected the white colour was because that was what the standard colour of the brackets without any bracket pair colorization. I would also caution against using the blue colour as it's the same colour as the text, which somewhat removes the benefit of colour differences in IDEs.

[miguelsolorio]

The reason I selected the white colour was because that was what the standard colour of the brackets without any bracket pair colorization

Doesn't this conflict with the feature? I think we'd want to mirror the original as close as possible while still matching the theme

I would also caution against using the blue colour as it's the same colour as the text, which somewhat removes the benefit of colour differences in IDEs

Fair point, I think an alternate color can work here as well

[hediet]

Doesn't this conflict with the feature? I think we'd want to mirror the original as close as possible while still matching the theme

I think it is actually not a bad idea to use white as one of three (or more) colors for specific themes: This feature is all about being able to see matching bracket pairs, not neccessarily about highlighting brackets from text.
The original extension does not support themeable colors anyway.

[TabithaLarkin]

@misolori Is there anything I can do to get this over the line? What's the blocker here?

[miguelsolorio]

Thanks for the ping, LGTM let's get this merged and see how it looks like on Insiders. Thank you!