Bracket Pair Colorization: Consider picking colors with a bit more contrast from syntax higlight

[IllusionMH]

In #129231 there was a discussion about contrast between brackets, however it would be also great to have a bit more contrast between bracket and tokens near it for default themes.

It mostly noticeable with light blue parentheses ( #87cefa) that looks almost same as to parameters and properties (#9cdcfe).
Constants(#4fc1ff) are slightly better.

function and log looks great near (

@hediet do you think it's possible to find blue value that distinct enough from other colors in syntax highlight or this is out of scope?

UPD. For example #179fff is brighter but I guess it's comparable to #ffd700.
Looks good with parameters/properties and constants, however closer to function and false, but still not as close as with parameters and properties now.

[hediet]

You can customize the colors:

"workbench.colorCustomizations": {
    "[Default Light+]": {
        "editorBracketHighlight.foreground1": "#0431FAFF", // #1857D0FF
        "editorBracketHighlight.foreground2": "#319331FF", // #167C4BFF
        "editorBracketHighlight.foreground3": "#7B3814FF", // #8A4F0CFF
    }
},

Please let us know if you find nice colors 😉
We mainly optimized for constrast / relative contrast. Though the colors for the dark theme are taken from the original bracket pair colorization extension.

[IllusionMH]

Main idea was to have better defaults for built-in themes if possible (I remember how hard was to find another blue color so it's questionable if there is good color for brackets).

I found #179fff or #33aaffas more preferable for me but it's more brighter so may not fit goal "draw less attention" if there is one.
Something from hue ~205, saturation ~90-100%, and lightness ~50-60%

If this change if out of scope - fell free to close this issue - I'll use local color overrides (as you've mentioned above).

[hediet]

Main idea was to have better defaults for built-in themes if possible

I got that, I wanted to encourage playing with colors and posting better ones 😉

I found #179fff or #33aaffas more preferable for me but it's more brighter so may not fit goal "draw less attention" if there is one.

Thanks, I'll try it out!

[hediet]

I updated the dark colors to use #179fff.

[TabithaLarkin]

This is what I use for Solarized Dark based off of the settings I had when I was using the bracket pair colorization extension. I just picked some colours that were already in use by the theme.

"[Solarized Dark]": {
    "editorBracketHighlight.foreground1": "#cdcdcdff",
    "editorBracketHighlight.foreground2": "#b58900ff",
    "editorBracketHighlight.foreground3": "#d33682ff",
}

This is what it looks like in practice.

[hediet]

@TabithaLarkin thanks! Feel free to open a PR to the repo that defines this theme! (also include a before screenshot)

[NatoBoram]

The new blue is a complete eyesore and has to be changed; it actively hurts the eyes.

The old extension had these colours:

{
  "bracket-pair-colorizer-2.colors": [
    "Gold",
    "Orchid",
    "LightSkyBlue"
  ]
}

• #ffd700
• #da70d6
• #87cefa

While they were pretty bright, aggressive, in-your-face and the blue was similar to the variable colour, they weren't hurting.

In the HTML coloured names, here's a few blue suggestions:

• CornflowerBlue #6495ED
• DeepSkyBlue #00BFFF
• DodgerBlue #1E90FF

Of these, I think DeepSkyBlue #00BFFF has the closest level of aggressiveness to the other two without bleeding out in the other pixels around it.

It looks okay.

[IllusionMH]

It look great with white, and slightly better then initial with variables.
However it's almost identical to constants/read-only values (#4FC1FF), therefore proposition was to pick value distinguishable from both of these colors.

[hediet]

Is this issue still relevant?

Otherwise, I'd suggest to close it and open more specific/actionable issues.