Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider expanding the number of configurable colors in new bracket pair colorization feature #134200

Closed
edtz opened this issue Sep 30, 2021 · 5 comments
Assignees
Labels
bracket-pair-colorization feature-request Request for new features or functionality

Comments

@edtz
Copy link

edtz commented Sep 30, 2021

Hello, I've been a user of vs code for quite some time and it's a stellar piece of software, thank you for making it!
As to the request at hand, I've been a fan of "Bracket Pair Colorizer" extension ever since I found it, and very happy it is now integrated into the core with a significant performance boost. Unfortunately, my config for the extension doesn't seem to be compatible with the native feature due to a maximum of 6 colors being supported, in my case I've been using a set of 8 colors that I feel have a distinct enough difference in hue to be useful:

["rgb(110, 64, 170)","rgb(65, 125, 224)","rgb(26, 199, 194)","rgb(64, 243, 115)","rgb(175, 240, 91)","rgb(239, 167, 47)","rgb(255, 94, 99)","rgb(210, 62, 167)"]

I would appreciate it if you considered increasing the limit, as to a concrete number I'm not sure what would be the optimal number, but I think 6 is too limiting.

@valtism
Copy link
Contributor

valtism commented Oct 8, 2021

I wanted to piggyback this issue because it is related, and I'm not sure it's worth opening a new issue for it.

I like the bracket colourisation, but I feel like using the default colours from the original extension (pink, yellow, blue) really clash with the default theme and I wish the default colours were more subdued. Customising the colours can absolutely do this for me, but I feel like the defaults should be nice enough that most people won't need to change them.

@hediet
Copy link
Member

hediet commented Oct 8, 2021

@valtism issues should have one topic, so we can close them with the commit that resolves it.

Please see #130989 for a discussion of colors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bracket-pair-colorization feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants
@valtism @hediet @edtz and others