Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aeschli/125786 #125817

Merged
merged 2 commits into from
Jun 9, 2021
Merged

aeschli/125786 #125817

merged 2 commits into from
Jun 9, 2021

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jun 9, 2021

Clarify string with command:. For #125786

  • adding a comment what to translaet and what nt
  • changing the key so that we don't get broken by existing old translations

@aeschli aeschli changed the base branch from main to release/1.57 June 9, 2021 07:49
@aeschli aeschli self-assigned this Jun 9, 2021
@aeschli aeschli added this to the May 2021 milestone Jun 9, 2021
@aeschli aeschli requested a review from alexr00 June 9, 2021 10:00
@@ -301,7 +301,11 @@ export class RemoteStatusIndicator extends Disposable implements IWorkbenchContr
const workspaceLabel = this.getWorkspaceLabel();
if (workspaceLabel) {
const toolTip: IMarkdownString = {
value: nls.localize('workspace.tooltip', "Virtual workspace on {0}\n\n[Some features](command:{1}) are not available for resources located on a virtual file system.", workspaceLabel, LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID),
value: nls.localize(
{ key: 'workspace.tooltip2', comment: ['[abc]({1}) is a link. Only translate `Some features`. Do not change brackets and parentheses or {1}'] },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the comment "abc" should say "Some features".

@aeschli aeschli merged commit b4c1bd0 into release/1.57 Jun 9, 2021
@aeschli aeschli deleted the aeschli/125786 branch June 9, 2021 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants