Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fixes #107860" #108210

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Revert "fixes #107860" #108210

merged 1 commit into from
Oct 7, 2020

Conversation

roblourens
Copy link
Member

This reverts commit b8e87aa.

Fixes #108202 and brings back #107860

Basically getActionViewItem can be called when the header is being created, before the body has been created, and so this.tree is undefined.

This reverts commit b8e87aa.
@roblourens roblourens added this to the September 2020 milestone Oct 6, 2020
@JacksonKearl JacksonKearl self-requested a review October 6, 2020 23:51
@roblourens roblourens merged commit 93c2f0f into release/1.50 Oct 7, 2020
@roblourens roblourens deleted the roblou/fix108202 branch October 7, 2020 00:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants