Broken Debug Console

[roblourens]

• Reload the window, ensure debug console is never opened
• Start debugging a launch config with "internalConsoleOptions": "neverOpen" or a launch config that fails to start/attach so that the debug console is never opened
  • I first hit this with a launch config that started normally, but I don't know how that's possible
• Start a second launch config that also never causes the debug console to open
• Open the debug console
• It's empty

Get a notification for this error

Hit the error in the debugger:

getActionViewItem (repl.ts:462)
actionViewItemProvider (viewPaneContainer.ts:299)
actionViewItemProvider (toolbar.ts:87)
(anonymous) (actionbar.ts:276)
push (actionbar.ts:261)
(anonymous) (toolbar.ts:167)
setActions (toolbar.ts:166)
setActions (viewPaneContainer.ts:483)
renderHeader (viewPaneContainer.ts:306)
render (paneview.ts:213)
render (viewPaneContainer.ts:271)
onDidAddViewDescriptors (viewPaneContainer.ts:1362)
create (viewPaneContainer.ts:1069)
create (panecomposite.ts:44)
showComposite (compositePart.ts:219)
doOpenComposite (compositePart.ts:150)
openComposite (compositePart.ts:114)
doOpenPanel (panelPart.ts:493)
openPanel (panelPart.ts:498)
run (panelActions.ts:189)
runAction (actions.ts:202)
run (actions.ts:194)
onClick (actionViewItems.ts:163)
(anonymous) (actionViewItems.ts:143)
processImmediate (internal/timers.js:439)

Seems that if the "select repl" action is valid at the time the viewPaneContainer is being created for the debug console, then it will invoke the actionViewItemProvider which assumes the tree has been instantiated already, but it hasn't yet, and it throws.

[roblourens]

From b8e87aa

[roblourens]

Actually it is easy to repro with the "VS Code" launch config. I guess I'm not sure what determines whether the debug console is shown or not when debugging starts because it is not shown for those configs.

[roblourens]

But I don't understand why the debug console is not opened for me when I start this config.

• Turn on "Smart" auto attach
• Run "Launch VS Code"
• I see it attach to some session that ends before it attaches to "Launch VS Code"
• Debug console does not open

---

• Disable auto attach
• Run "Launch VS Code"
• Debug console does open

And when the debug console does not open early and get a chance to initialize itself, that's when this bug is triggered.

[roblourens]

It looks like @isidorn is out, so going ahead with a fix.

Decided to just revert the fix for #107860

I think the right fix would be to figure out what the current session is without looking at the tree, which I think is possible but I'll leave that for @isidorn. Or, create the tree earlier.

Then broke out the question of why the debug console doesn't appear when maybe it should, which makes this much easier to repro, into a separate issue.

[roblourens]

Simplest repro steps

• Reload window, don't open debug console
• Set Auto attach -> Smart
• Run the "VS Code" launch config
• Try to open the debug console

[connor4312]

@JacksonKearl did you verify when you approved? If not I can verify this issue

[roblourens]

It will need to be verified but the build is not released yet

[roblourens]

Now it is

[isidorn]

@roblourens thanks for jumping on this and for finding the root cause.