Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure where editors open #6787

Closed
jrieken opened this issue May 24, 2016 · 10 comments
Closed

Allow to configure where editors open #6787

jrieken opened this issue May 24, 2016 · 10 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented May 24, 2016

#6536

  • see attach gif
  • from a folder I have two files pinned
  • from the folder I know preview each file and I don't understand why determines their sort order

may-24-2016 14-45-43

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues labels May 24, 2016
@bpasero
Copy link
Member

bpasero commented May 24, 2016

@jrieken actually @joaomoreno was also confused by this but I am trying to mimic what a tab folder would do: the fact that an editor is in preview mode means that when you open another preview editor, we close the one you have first and then open the other one +1 to the right of the currently one (that is all "tabs" would open to the right of the currently active one).

In this case it looks weird because one preview editor closes from the end and the other opens to the side.

@stevencl @bgashler1 interested to hear your feedback here if you would expect the preview editor to move or stay at the position.

@bpasero bpasero added the ux User experience issues label May 24, 2016
@bpasero bpasero added this to the June 2016 milestone May 24, 2016
@joaomoreno
Copy link
Member

It is not as much moving it as it is placing it.

I wouldn't find it so weird if any new editor would always open at the end of its group.

@jrieken
Copy link
Member Author

jrieken commented May 24, 2016

I wouldn't find it so weird if any new editor would always open at the end of its group.

that

@bpasero
Copy link
Member

bpasero commented May 24, 2016

@joaomoreno @jrieken maybe you could comment on #6812

I am wondering if we should remove the whole idea of showing the preview entry under "opened editors". I think it would fix some issues.

@bgashler1
Copy link
Contributor

See my comment at #6812 (comment)

@bpasero
Copy link
Member

bpasero commented May 25, 2016

@stevencl @bgashler1 I wonder if the user has tabs disabled if we should always just open tabs at the end of the list, similar to working files. Because if tabs are not enabled, the only spatial order that you have is the one in opened editors and there it might make more sense to always open at the end.

@joaomoreno
Copy link
Member

I would keep away from separate behaviours when certain things are enabled or not. Remember that it has repercussions on others features such as Ctrl Tab.

@bpasero
Copy link
Member

bpasero commented May 25, 2016

@joaomoreno actually Ctrl+Tab moves in MRU order, so the spatial order does not make any impact here.

@bpasero bpasero added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels May 25, 2016
@bpasero bpasero changed the title non obvious sorting in Open Editors view Allow to configure where editors open May 25, 2016
@bpasero
Copy link
Member

bpasero commented May 25, 2016

UX meeting outcome: we think we should provide a setting that allows a user to decide where new editors open. We need this already for tabs (to the right of active editor, to the left of active editor) and we could just let this be an enum with more values (to the beginning of all editors, at the end). Setting this to "at the end" would restore pretty much how working files used to behave.

@bpasero
Copy link
Member

bpasero commented Jun 14, 2016

Discussion on settings names continues in #7643

@bpasero bpasero closed this as completed Jun 14, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants