-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure where editors open #6787
Comments
@jrieken actually @joaomoreno was also confused by this but I am trying to mimic what a tab folder would do: the fact that an editor is in preview mode means that when you open another preview editor, we close the one you have first and then open the other one +1 to the right of the currently one (that is all "tabs" would open to the right of the currently active one). In this case it looks weird because one preview editor closes from the end and the other opens to the side. @stevencl @bgashler1 interested to hear your feedback here if you would expect the preview editor to move or stay at the position. |
It is not as much moving it as it is placing it. I wouldn't find it so weird if any new editor would always open at the end of its group. |
that |
@joaomoreno @jrieken maybe you could comment on #6812 I am wondering if we should remove the whole idea of showing the preview entry under "opened editors". I think it would fix some issues. |
See my comment at #6812 (comment) |
@stevencl @bgashler1 I wonder if the user has tabs disabled if we should always just open tabs at the end of the list, similar to working files. Because if tabs are not enabled, the only spatial order that you have is the one in opened editors and there it might make more sense to always open at the end. |
I would keep away from separate behaviours when certain things are enabled or not. Remember that it has repercussions on others features such as Ctrl Tab. |
@joaomoreno actually Ctrl+Tab moves in MRU order, so the spatial order does not make any impact here. |
UX meeting outcome: we think we should provide a setting that allows a user to decide where new editors open. We need this already for tabs (to the right of active editor, to the left of active editor) and we could just let this be an enum with more values (to the beginning of all editors, at the end). Setting this to "at the end" would restore pretty much how working files used to behave. |
Discussion on settings names continues in #7643 |
#6536
The text was updated successfully, but these errors were encountered: