Revisit that preview editors show up under "Opened Editors"

[bpasero]

Some issues:

• for one it makes it very hard to double click on a file in the explorer to pin it because the first mouse down adds it already and pushes down the view
• then people are confused that the preview editor is open in one position but when you open another editor the preview editor might move up because that other editor was elsewhere
• Joao also does not like the italic decoration when you have tabs disabled
• so one proposal would be: only show italics when tabs are enabled and only show it in the tab itself
  (of course we would have to revisit where else we show the italic, e.g. Ctrl+Tab, Cmd+Alt+Tab)

[bgashler1]

Why it might be good to remove them:

• I also haven't been loving the italicized text in Open Editors now that I've been using it. I didn't feel like it was strong enough of an indicator to help me find a preview editor that was buried somewhere in a group (it's like a needle in a haystack--I ). I didn't notice that the preview editor was moving in the group, but after seeing @jrieken's gif, I see why this is confusing.
• Sublime also does not show preview tabs in their Open Files pane, but they do get their own temporary tab, and personally that makes sense to me for the most part.

Why it might be bad to do so:

• With tabs disabled, it may be confusing after closing a file that a mysterious preview file that was hiding in the stack shows up instead of the file shown above in working files.
• It may be less obvious how to pin a "Diff view" or some other kind of special editor, because it does not have something you can double click (perhaps we could allow double clicking the editor's title shown at the top of the group).

Ideas on making it work as is:

I thought about how we might solve this without eliminating preview editors completely from the list.

1. Use smooth motion transitions (like Chrome and Sublime do with tabs)
2. Always leave a dedicated space at the end of each group's list in Open Editors so that opening/closing a preview editor will never shift the Explorer files up or down.

Look at this crude prototype that demonstrates how smooth motion transitions might make it more clear what's going on in the stack.

Thoughts?

[bpasero]

@bgashler1 interesting idea, if I understood you correctly, we would keep an empty slot for each possible preview editor. It would look like this:

While it fixes the issue with annoying double click behaviour, it almost looks like a UI bug that we would grow the "Opened Editors" view with an empty element inside.

Let's discuss this in the next planning meeting :)

[joaomoreno]

Interesting... but doesn't it look ugly?

[bpasero]

Summary from the UX meeting regarding the concerns:

• we will fix the double click issue without having to hide the preview tab (Animated open editors make me open two files on double click #6749)
• we will provide an option to configure sorting behaviour of new editors (Allow to configure where editors open #6787)
• we would like to test out the italics experience even when tabs are disabled to see if we can get used to it.

That way we think having preview tab in "opened editors" is really not a bad thing to have.

[bgashler1]

@bpasero and @joaomoreno yes, the blank space sounded good in my head until I saw it. Definitely not pretty.