Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor hover can overflow to top of screen #60534

Closed
gggustafson opened this issue Oct 10, 2018 · 10 comments
Closed

Editor hover can overflow to top of screen #60534

gggustafson opened this issue Oct 10, 2018 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover wont-fix
Milestone

Comments

@gggustafson
Copy link

I am using flutter/dart in VS Code on Windows 7 SP1

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.8.2, on Microsoft Windows [Version 6.1.7601], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] VS Code, 64-bit edition (version 1.28.0)
[√] Connected devices (1 available)

• No issues found!

When I hover over a recognized object, a tooltip popup appears. A problem is that if the object over which I hover is close to the top of the screen, the tooltip appears too far up; its top contents are hidden; and I have to reposition the object lower on the screen.

The first image displays the tooltip positioning problem. I have hovered over Column (line 78) where Column is near the top of the screen.

tooltip_too_high

The second image displays the tooltip when Column has been scrolled downward towards the center of the screen.

tooltip_ok

It appears that tooltips require 9 lines. So through simple computations, the tooltip could be placed so that all 9 lines of the tooltip appear near the object it is discussing without clipping.

@vscodebot
Copy link

vscodebot bot commented Oct 10, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor-contrib Editor collection of extras label Oct 10, 2018
@gggustafson
Copy link
Author

Since I am using VS Code 1.28, the vscodebot once again provides worthless information. The suggested issue has absolutely nothing to do with the issue I raise!!

@egamma egamma added the *caused-by-extension Issue identified to be caused by an extension label Oct 10, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2018

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2018
@egamma
Copy link
Member

egamma commented Oct 10, 2018

The bot can be understood since this issue is about the flutter extension, please file the issue against this repository.

@DanTup
Copy link
Contributor

DanTup commented Oct 10, 2018

@egamma I'm the author of the extension and advised @gggustafson to post here. I don't know how the extension can control this (I actually raised a similar bug years ago -> #10051).

If you believe I can fix this, please give me a pointer.

@egamma
Copy link
Member

egamma commented Oct 10, 2018

@DanTup I´m deeply sorry you are absolutely right.

@egamma egamma reopened this Oct 10, 2018
@egamma egamma removed the *caused-by-extension Issue identified to be caused by an extension label Oct 10, 2018
@joaomoreno joaomoreno removed the editor-contrib Editor collection of extras label Oct 11, 2018
@joaomoreno
Copy link
Member

/duplicate #57088

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 11, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 11, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 11, 2018
@gggustafson
Copy link
Author

This issue is not a duplicate of #57088. That issue was concerned with the size of the popup. This issue regards the positioning of the popup. This issue is the same as #10051. But that was reported on Aug 2, 2016 by the extension author. It has not been fixed!!!

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover and removed *duplicate Issue identified as a duplicate of another issue(s) labels Oct 16, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Oct 16, 2018
@joaomoreno joaomoreno reopened this Oct 16, 2018
@joaomoreno
Copy link
Member

@gggustafson Thanks for the heads up.

@octref octref added editor-hover Editor mouse hover and removed editor-hover Editor mouse hover labels Oct 25, 2019
@octref octref changed the title flutter/dart popup tooltips poorly positioned Editor hover can overflow to top of screen Oct 25, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover wont-fix
Projects
None yet
Development

No branches or pull requests

5 participants