Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter/dart popup tooltips poorly positioned #22912

Closed
gggustafson opened this issue Oct 10, 2018 · 9 comments
Closed

flutter/dart popup tooltips poorly positioned #22912

gggustafson opened this issue Oct 10, 2018 · 9 comments

Comments

@gggustafson
Copy link

I am using VS Code on Windows 7 SP1

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.8.2, on Microsoft Windows [Version 6.1.7601], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] VS Code, 64-bit edition (version 1.28.0)
[√] Connected devices (1 available)

• No issues found!

When I hover over a recognized object, a tooltip popup appears. A problem is that if the object over which I hover is close to the top of the screen, the tooltip appears too far up; its top contents are hidden; and I have to reposition the object lower on the screen.

The first image displays the tooltip positioning problem. I have hovered over Column (line 78) where Column is near the top of the screen.

tooltip_too_high

The second image displays the tooltip when Column is located towards the center of the screen.

tooltip_ok

It appears that tooltips require 9 lines. So through simple computations, the tooltip could be placed so that all 9 lines appear near the object it is discussing.

@zoechi
Copy link
Contributor

zoechi commented Oct 10, 2018

@DanTup

@DanTup
Copy link
Contributor

DanTup commented Oct 10, 2018

@gggustafson Thanks for the report! The positioning of the hovers is controlled by VS Code, so this seems like a bug there. (By coincidence, it looks like this issue I raised many years ago). Would you mind raising it there and post the link back here?

@gggustafson
Copy link
Author

gggustafson commented Oct 10, 2018

Microsoft/vscode flutter/dart popup tooltips poorly positioned microsoft/vscode#60534

@DanTup
Copy link
Contributor

DanTup commented Oct 10, 2018

Thanks! Seems like it was closed unfairly - I don't believe I can fix it; the hover provider is unable to influence the rendered position. I've added a comment and will see what comes back.

@gggustafson
Copy link
Author

Sorry for the trouble. Seems MS is a little touchy.

The problem is cosmetic and does have a workaround - position the hovered item in the center of the screen. Even still I believe it is a bug.

@zoechi
Copy link
Contributor

zoechi commented Oct 10, 2018

Can this issue be closed here and maintained in Microsoft/vscode?
It doesn't look like the Flutter team can do anything here.

@gggustafson
Copy link
Author

Yes, let's close this. I will look to MS to add info to their copy.

@DanTup
Copy link
Contributor

DanTup commented Oct 10, 2018

VS Code team have re-opened the related issue and there's nothing we can do here (we can't even provide a workaround, since the rendering code is entirely Codes), so closing makes sense. Thanks for bringing it up all the same! 👍

@DanTup DanTup closed this as completed Oct 10, 2018
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants