Hover popups always seem to go up, even for first line of file (going offscreen)

[DanTup]

• VSCode Version: 1.3.1
• OS Version: Windows 10

For some reason, the hover information provided by my extension always goes up and gets chopped off; even though the built-in TypeScript one does not!

TypeScript (left) has the hover popup appear below the mouse, whereas mine (right) shows it above.

My code looks like this (I've checked but can't see anything on the related classes that might let me control this):

export class DartHoverProvider implements HoverProvider {
    private analyzer: Analyzer;
    constructor(analyzer: Analyzer) {
        this.analyzer = analyzer;
    }

    provideHover(document: TextDocument, position: Position, token: CancellationToken): Thenable<Hover> {
        return new Promise<Hover>((resolve, reject) => {
            this.analyzer.analysisGetHover({
                file: document.fileName,
                offset: document.offsetAt(position)
            }).then(resp => {
                if (resp.hovers.length == 0)
                    resolve(null);
                else
                    // TODO: Add Range
                    resolve(new Hover(resp.hovers.map(this.getHoverData)));
            });
        });
    }

    private getHoverData(hover: as.HoverInformation): string {
        return (
            (hover.dartdoc != null ? hover.dartdoc + "\r\n" : "")
            + hover.elementDescription
        ).trim();
    }
}

[alexdima]

@DanTup The UI code that renders the hovers doesn't care about where the hover comes from, but cares about the height of the hover. Is it possible to share here the values you provide to a hover? (I'm thinking it is a very large text blob?)

[DanTup]

@alexandrudima You're right, it was large. We've since trimmed it down to 20 lines and I think it's been fine since. I think there's an open feature request to add scrolling somewhere (which I think would be a better long-term solution).

If you need a specific example to repro, let me know and I'll find one.

[alexdima]

@joaomoreno I think we've added scrolling in the hover since this issue was created, right ?

[joaomoreno]

@alexandrudima Talk about digging. 👴