Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GitHub Pull Request Extension #57301

Closed
3 tasks done
RMacfarlane opened this issue Aug 27, 2018 · 1 comment
Closed
3 tasks done

Test GitHub Pull Request Extension #57301

RMacfarlane opened this issue Aug 27, 2018 · 1 comment

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Aug 27, 2018

Refs: microsoft/vscode-pull-request-github#1

Complexity: 5

This is to test the GitHub PR extension. Please file any issues you run into in the extension's repository.

Setup

  • Download the latest visx from our release page
  • Install the vsix in latest Insider

Testing

This repo can be used to test against if you don't have other PRs to use: https://github.com/auchenberg/pullrequest-demo

Some things to try/verify:

Authentication

  • When first using the extension, you are prompted by a notification to sign in

Pull Request tree view:

  • View pull requests in SCM viewlet when a GitHub repository is opened in VSCode, the predefined categories work as expected.
  • View file changes from the Pull Request tree view and create comments within these.
  • View the description page for a pull request, the timeline events of a pull request are rendered properly.
  • Can approve or reject a PR from the description page.
  • Leave generic issue comments in the description page for a pull request.
  • If the repository contains many PRs, a load more button appears for the category within the tree and works as expected.

Review mode

  • Checkout to a pull request from Pull Request description page or content menu of Pull Request tree view works, the comments panel and additional "Changes in Pull Request" tree view shows up in the SCM viewlet.
  • Navigate through comments in the Command Panel.
  • View/Create comments in a normal editor.
  • Comments positions are adjusted when you make changes to local content.
  • The "Changes in Pull Request" view lists file changes and all commits in the PR.
  • After modifying/adding/deleting comments for the pull request on GitHub, comments within VSCode are updating to reflect this within a minute.
@RMacfarlane RMacfarlane added this to the August 2018 milestone Aug 27, 2018
This was referenced Aug 28, 2018
@RMacfarlane
Copy link
Contributor Author

Please grab the latest version of the extension when testing today: https://github.com/Microsoft/vscode-pull-request-github/releases/tag/0.0.18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants