Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the diff on a large diff will send the user to the new file on GitHub, not a diff view #305

Closed
Tyriar opened this issue Aug 28, 2018 · 0 comments
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2018

microsoft/vscode#57301

Opening node.d.ts in microsoft/vscode#56149 will open https://github.com/Microsoft/vscode/blob/ed7cff112268ee9e9434a96d11c0a5a10d7fb073/src/typings/node.d.ts, I expected it to show the diff instead. Also ideally it would show inside VS Code.

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants