Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff from fork point state to current file state #288

Closed
alexdima opened this issue Aug 28, 2018 · 4 comments
Closed

Diff from fork point state to current file state #288

alexdima opened this issue Aug 28, 2018 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@alexdima
Copy link
Member

Testing microsoft/vscode#57301

I've been wanting to file this one for a few days already. I would prefer if, once I checked out a PR, that the "Changes in Pull Request view" would open on the left hand side the fork point (as it does today) and on the right hand side the file, as it is on disk.

Today, the Changes in PR view opens on the right hand-side a read-only file where I cannot edit and it is super annoying, I need to press a button to get to the file if I want to remove like a newline. Once I remove a newline, the Git viewlet shows me the diff of removing the line, but I want to see the final diff of the PR i.e. (fork point <-> current file state).

I know this is quite a change, but IMHO that would make it a lot more useful for me... I always think of a PR in terms of fork point <-> final PR state and I want the diffs to be as small as possible...

@rebornix rebornix self-assigned this Aug 28, 2018
@rebornix rebornix added the feature-request Request for new features or functionality label Aug 28, 2018
@rebornix
Copy link
Member

We can make this closer to the Git SCM experience and leverage the git schemes.

@joaomoreno do you think it's a good idea to depend on how Git extension generates the document Uri?

@joaomoreno
Copy link
Member

@rebornix Absolutely. I'm even considering making it git extension API: microsoft/vscode#55110

@kieferrm kieferrm mentioned this issue Jan 14, 2019
20 tasks
@RMacfarlane
Copy link
Contributor

Completed with #828

@alexdima
Copy link
Member Author

This is great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants