Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to contribute defaults for built in configurations #46851

Closed
DanTup opened this issue Mar 28, 2018 · 7 comments
Closed

Allow extensions to contribute defaults for built in configurations #46851

DanTup opened this issue Mar 28, 2018 · 7 comments
Assignees
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 28, 2018

Currently Code has special knowledge of some folders that shouldn't be looked in, such as:

"files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true
  },

For the same reason that these folders are in there, extensions may wish to contribute their own folders (for example we'd like to exclude the .dart_tool folder).

As far as I can tell, this isn't currently possible. I tried adding it to configurationDefaults in package.json in the hope I'd be merged with that object but it just seems to have no effect.

Is there a way that I can provide values to be added to files.watcherExclude, files.exclude, search.exclude?

@vscodebot
Copy link

vscodebot bot commented Mar 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@sandy081
Copy link
Member

@DanTup Why don't you update the setting when your extension is activated?

@sandy081 sandy081 added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 29, 2018
@DanTup
Copy link
Contributor Author

DanTup commented Mar 29, 2018

@sandy081 That could work, though it has some drawbacks:

  1. The docs say this doesn't take effect until you restart Code
  2. It kinda pollutes the users config (especially if we add it for files.watcherExcludes, files.ignore, search.ignore; esp. if we need to include all the defaults too, since the value gets replaced, not merged?)

I think it'd be better if extensions could declare these in package.json and VS Code merges them all at startup (I guess it already reads the manifests at startup for commands, etc.). node_modules currently gets special treatment that other projects can't have.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed feature-request Request for new features or functionality labels Mar 29, 2018
@sandy081 sandy081 changed the title Allow extensions to contribute exclusion paths (eg. files.watcherExclude) Allow extensions to contribute defaults for built in configurations Mar 29, 2018
@sandy081 sandy081 added this to the April 2018 milestone Mar 29, 2018
@sandy081
Copy link
Member

sandy081 commented Apr 5, 2018

Supporting overriding configuration defaults might need adoption from all those settings which need restart. Because, they might go in a loop when there is a change in configuration value due to defaults change.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 19, 2018
@sandy081 sandy081 modified the milestones: April 2018, Backlog Apr 19, 2018
@yaohaizh
Copy link

Second this, redhat-developer/vscode-java#618

We also have similar request to hide some files for Java language specifically. But this files.exclude cannot be enabled on package.json.

@sandy081 sandy081 modified the milestones: Backlog, On Deck Sep 11, 2018
@akaroml
Copy link
Member

akaroml commented Oct 31, 2018

Java users have been complaining about the temporary files generated for handling a project. The temp files can be generated at any stage and can change as long as users change project settings. Restarting everytime does not look appealing. So we really need vscode to address this issue for us to hide those temp files without reloading window.

@Hezkore
Copy link

Hezkore commented Jun 17, 2019

I guess there's no chance of this ever being implemented?
The referenced issue has been closed.
A real shame, I'd really like to hide some stuff my language compiler spits out.

@sandy081 sandy081 added this to the November 2021 milestone Nov 24, 2021
sandy081 added a commit that referenced this issue Nov 25, 2021
sandy081 added a commit that referenced this issue Nov 26, 2021
… serializable.

Pass only id and display name as extension info
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
…it is not serializable.

Pass only id and display name as extension info
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

No branches or pull requests

7 participants
@bpasero @DanTup @Hezkore @sandy081 @akaroml @yaohaizh and others