Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaultConfiguration instead of pop up notification #138

Open
jrieken opened this issue Nov 6, 2019 · 4 comments
Open

Use defaultConfiguration instead of pop up notification #138

jrieken opened this issue Nov 6, 2019 · 4 comments

Comments

@jrieken
Copy link

jrieken commented Nov 6, 2019

We are trying to reduce the amount of pop-ups (read noise) users are getting on first start or when installing extensions. IntelliCode is on the radar because of this:

Screenshot 2019-11-06 at 12 48 14

I remember there has been a discussion about us changing/not changing the default for all of VS Code - something we have no plans at this time. However, the pop-up-solution isn't a good outcome and IntelliCode should make use of configuration defaults. They allow, per language, to change the default of a setting, e.g.

{
  "contributes": {
    "configurationDefaults": {
      "[java]": {
        "editor.suggestSelection": "first",
      }
    }
  }
}

will turn suggest selection to first for all Java as long as IntelliCode is installed. This yield the better default, avoids prompting users directly after install, and doesn't conflict with user settings.

@vivlimmsft
Copy link
Collaborator

We used to use configurationDefaults, but the issue we encountered is that if someone wanted to override our default and force a different option, such as recentlyUsedByPrefix, they had to specify language specific overrides for all of the languages we support to override our defaults, i.e.:

    "[javascript]": {
        "editor.suggestSelection": "recentlyUsedByPrefix"
    },
    "[typescript]": {
        "editor.suggestSelection": "recentlyUsedByPrefix"
    },
    "[java]": {
        "editor.suggestSelection": "recentlyUsedByPrefix"
    },
    "[python]": {
        "editor.suggestSelection": "recentlyUsedByPrefix"
    }

If they didn't, our default would still take precedence over their editor.suggestSelection config.
(See #53 (comment) for our prior discussion on this)

The main reason we went with this approach is that there isn't (wasn't?) a way to define configurationDefaults which apply to all languages.

@jrieken
Copy link
Author

jrieken commented Nov 21, 2019

This should help: microsoft/vscode#46851. It's planned for the not so distant future 👀 /cc @sandy081

@markw-t
Copy link
Contributor

markw-t commented Apr 1, 2021

Reopening due to erroneous bot closure. Apologies for any confusion

@github-actions
Copy link

github-actions bot commented May 1, 2021

Automatically marked uncategorized issue as product feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants