Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve find in terminal #28768

Closed
4 of 7 tasks
Tyriar opened this issue Jun 15, 2017 · 5 comments
Closed
4 of 7 tasks

Improve find in terminal #28768

Tyriar opened this issue Jun 15, 2017 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2017

Basic find in terminal functionality was added in #15198. Here are some of the improvements we can make

Upstream improve find API issue: xtermjs/xterm.js#705

/cc @rebornix

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Jun 15, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 15, 2017
@Tyriar Tyriar self-assigned this Jun 15, 2017
@Tyriar Tyriar modified the milestones: June 2017, July 2017 Jun 22, 2017
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 7, 2017
@Tyriar Tyriar modified the milestones: Backlog, July 2017 Jul 17, 2017
@JacksonKearl JacksonKearl self-assigned this Jul 26, 2018
@noamyogev84
Copy link
Contributor

@Tyriar is this something I can try to work on? if so, some code pointers?

@Tyriar
Copy link
Member Author

Tyriar commented Sep 21, 2018

@noamyogev84 some of this got fixed recently: #58826

For the other parts, you can refer to the individual issues in xterm.js: https://github.com/xtermjs/xterm.js/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+label%3Aaddon+search+addon

The search "addon" is located in ./src/addons/search in the xterm.js repo.

@dalDevelo
Copy link

I've just come to add my voice for improved terminal features in VSCode. My main issues at the lack of ability to adjust the 'found search term' highlighting. It would be great if you could adjust this, even if it was to pick from a selection of pre-defined highlight colours. The current grey highlighting is not visible enough IMO. I often struggle to see the found term quickly. Alternatively, a flashing 'on selection' highlight would be helpful as the macOS terminal has...

search_flash_highliting

@Yanpas
Copy link
Contributor

Yanpas commented May 21, 2019

KDE's Konsole has the most handy search. The most needed feature is highlighting all matches.

image

@Tyriar
Copy link
Member Author

Tyriar commented Oct 11, 2021

Moved remaining items into more actionable individual feature requests #134791, #134790

@Tyriar Tyriar closed this as completed Oct 11, 2021
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed feature-request Request for new features or functionality labels Oct 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

5 participants