-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve find in terminal #28768
Comments
@Tyriar is this something I can try to work on? if so, some code pointers? |
@noamyogev84 some of this got fixed recently: #58826 For the other parts, you can refer to the individual issues in xterm.js: https://github.com/xtermjs/xterm.js/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+label%3Aaddon+search+addon The search "addon" is located in |
I've just come to add my voice for improved terminal features in VSCode. My main issues at the lack of ability to adjust the 'found search term' highlighting. It would be great if you could adjust this, even if it was to pick from a selection of pre-defined highlight colours. The current grey highlighting is not visible enough IMO. I often struggle to see the found term quickly. Alternatively, a flashing 'on selection' highlight would be helpful as the macOS terminal has... |
Basic find in terminal functionality was added in #15198. Here are some of the improvements we can make
Highlight all instances of term in current viewportMoved to Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790Use a different selection type so that regular selection isn't hijacked, plus a color with a higher contrast can be used.Moved to Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790Add "No results" label, need to think about what to show in the gap when there are results. We probably shouldn't be searching the entire buffer when we don't have to for performance reasons.Moved to Terminal Find: Show result count #134791Upstream improve find API issue: xtermjs/xterm.js#705
/cc @rebornix
The text was updated successfully, but these errors were encountered: