Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Find: Show result count #134791

Closed
Tyriar opened this issue Oct 11, 2021 · 5 comments · Fixed by #146358
Closed

Terminal Find: Show result count #134791

Tyriar opened this issue Oct 11, 2021 · 5 comments · Fixed by #146358
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal Integrated terminal issues terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
April 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2021 •
edited
Loading

Forked off from #28768

Upstream issue: xtermjs/xterm.js#1659

Add "No results" label, need to think about what to show in the gap when there are results. We probably shouldn't be searching the entire buffer when we don't have to for performance reasons. We want to align with the editor's behavior as close as possible.
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Oct 11, 2021
@Tyriar Tyriar added this to the Backlog milestone Oct 11, 2021
@Tyriar Tyriar mentioned this issue Oct 11, 2021
Closed
7 tasks
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 11, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2022

Since we're now doing a full search when decorations are enabled (#134790) we should show the result count as well. Tentatively assigning to April

@Tyriar Tyriar modified the milestones: Backlog, April 2022 Mar 22, 2022
@amanasifkhalid
Copy link
Member

Hi, may I work on this one? Thanks!

@Tyriar
Copy link
Member Author

Tyriar commented Mar 23, 2022

@amanasifkhalid sorry, we've already started work on it 🙂

@Tyriar Tyriar removed the help wanted Issues identified as good community contribution opportunities label Mar 23, 2022
@Tyriar Tyriar mentioned this issue Mar 23, 2022
Closed
This was referenced Mar 23, 2022
Closed
Closed
@Tyriar Tyriar added the terminal-find Relating the terminal's find widget label Mar 28, 2022
This was referenced Mar 28, 2022
Closed
Merged
@meganrogge meganrogge mentioned this issue Apr 25, 2022
Closed
3 tasks
@rbadapanda
Copy link

The result shows '17 of 17' but does not change when user moves to the next/previous match.

So this feature looks incomplete.

Either fix for the expected behavior as above or change the text to something like 'total matches: 17'

@meganrogge
Copy link
Contributor

@rbadapanda that's been fixed now

@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal Integrated terminal issues terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

add find count to the terminal microsoft/vscode
5 participants
@Tyriar @rbadapanda @meganrogge @amanasifkhalid and others