Terminal: find widget gives flaky results

[isidorn]

1. Terminal, open find widget, find something -> works fine
2. Try to find some other term -> sometimes fails
3. If there are multiple instances of a result, sometimes moving between them fails

I can repro this flaky behavior both on my OS X with zsh shell and Win10 with powershell.
If nobody reported this so far please let me know and I will try to find better repro steps.

[Tyriar]

This is the first report, more details steps please 😃

[isidorn]

Ok here are steps which always repro on my os x zsh shell

1. vscode repo, terminal, do a ls
2. cmd + f, search for something, get results, search for something else no results

I can also repro on my win10 powershell but not so consistently

[cleidigh]

@isidorn
@Tyriar
@rebornix

I can also see this frequently on Windows 7/CMD.EXE
Usually the second search term fails, however this is not one hundred percent consistent.
Once the problem occurs, it appears to be "permanent" until you kill the terminal instance and start a new one. Probably an upstream issue?

Update/another observation:

• The problem appears to also be cleared if you press Escape to hide the simpleFind and then a second
  Escape to clear the selected find text(within the terminal)

• Open simpleFind again, enter a new search term - seems to work again.

• This problem can also be seen with stable Code 1.15.1 (prior to changes in simpleFind)

I think I may have seen this while working on simpleFind but was possibly fooled by Dragon issues.

@isidorn - what screen capture to use that is good for github ? and works on Windows.

[isidorn]

@cleidigh the creen capture I use is liceCap and I use it on my mac. Not sure if there is one for Windows though

[Tyriar]

@isidorn I'm not sure I understand, are you saying that the search for "blogs" should clear the selection?

Also the terminal find does not search the line that the selection is on, this is a known limitation and captured in another issue.

[cleidigh]

@Tyriar
cc @isidorn
I just redid my tests taking into account the above. I noted the current selection with subsequent finds
and what I see matches your description of the other issue/limitation @Tyriar .
If I do a search making sure to look for something on another line things appear to be okay. my guess is this is the same issue not a different one.

[cleidigh]

@isidorn
LiceCap is available for Windows and seems to work well Thanks!

[isidorn]

@Tyriar yes I am saying that the search for "blogs" should clear the selection and then select "blogs".
After trying a bit more I seem to be always hitting the issue you mentioned - I do not get the search results on the current line. This seems like a big limitation and makes the find widget very unrealiable in terminal imho

[Tyriar]

@isidorn there are many issues with the implementation, this was something @rebornix and I threw together over 1-2 days that wasn't planned for that iteration. Many of the improvements are listed here #28768

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.

[isidorn]

Reopening as I have provided enough details and that is not the issue ehre.
It might be a duplicate but leaving that up to @Tyriar to decide

[Tyriar]

Let's close this off in favor of #28768, I think it captures everything 😃