Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling file node in Comments view focuses comment #194236

Closed
joyceerhl opened this issue Sep 26, 2023 · 5 comments · Fixed by #194269
Closed

Toggling file node in Comments view focuses comment #194236

joyceerhl opened this issue Sep 26, 2023 · 5 comments · Fixed by #194269
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@joyceerhl
Copy link
Collaborator

Testing #194012

  1. Checkout Allow hiding of launcher on Run and Debug title bar when debugging #193812
  2. Open comments view
  3. Have debug.contribution.ts open and scrolled to the top of the file
  4. Hit enter in the debug.contribution.ts node
  5. 🐛 I get scrolled to the first comment
@joyceerhl joyceerhl changed the title Collapsing comment section in Comments view focuses comment Toggling file node in Comments view focuses comment Sep 26, 2023
@joyceerhl
Copy link
Collaborator Author

This also happens if I expand the node after collapsing it, which I found a bit surprising, as I didn't hit enter on a specific comment, just the file node

@meganrogge meganrogge removed their assignment Sep 26, 2023
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Sep 27, 2023
@alexr00 alexr00 added this to the September 2023 milestone Sep 27, 2023
@alexr00
Copy link
Member

alexr00 commented Sep 27, 2023

There are a couple problems here:

  • We should only expand/collapse the file node when the twisty is clicked/entered (we should have both an action and an expand/collapse with the file is clicked/entered)
  • We should just open the file and not scroll to a comment when the file node is clicked/entered.

@alexr00
Copy link
Member

alexr00 commented Sep 27, 2023

Actually, since you're opening the file from the Comments view, it makes sense to reveal the first comment. I'm just going to fix the expand/collapse + action issue.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 27, 2023
@andreamah andreamah added the verified Verification succeeded label Sep 27, 2023
@andreamah
Copy link
Contributor

I just verified this by making sure that clicking on the node doesn't expand/collapse the node (only the twistie can). Please lmk if that's sufficient!

@alexr00
Copy link
Member

alexr00 commented Sep 28, 2023

That is sufficient!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants