Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test comments accessibility #194012

Closed
3 tasks done
alexr00 opened this issue Sep 25, 2023 · 1 comment
Closed
3 tasks done

Test comments accessibility #194012

alexr00 opened this issue Sep 25, 2023 · 1 comment

Comments

@alexr00
Copy link
Member

alexr00 commented Sep 25, 2023

Refs: microsoft/vscode-pull-request-github#1930, #192377

Complexity: 4

Authors: @alexr00, @meganrogge

Create Issue


Comments can be tested using the GitHub Pull Requests and Issues extension.

  1. Install the pre-release version of GitHub Pull Requests and Issues.
  2. Check out a PR that has some comments, or expand a PR that has comments in the "Pull Requests" view.
  3. Toggle "Screen reader accessibility" mode on.
  4. Using a screen reader, verify that when you open a file with commenting ranges that you hear a status read that the editor has commenting ranges.
  5. Verify that if you open the editor accessibility help menu (alt + F1) in a file with commenting ranges that the help menu include useful information about navigating comments.
  6. Try out the comment help from the accessibility help menu. Verify that you can use the listed keyboard shortcuts for comments.
  7. Open the "Comments" view. Use your keyboard to navigate through the "Comments" view. Verify that enter causes the comment to be revealed and focused. Verify that space just reveals the comment.
  8. When a comment widget gets focused, verify that you hear about accessibility help. Trigger that (alt + F1) and verify it has useful information / walks a person through what they should expect.
  9. Disable accessibility.verbosity.comments and verify that you no longer hear the hint to open accessibility help when you focus a comment widget, an editor with comments, or a diff editor with comments.
@alexr00 alexr00 added this to the September 2023 milestone Sep 25, 2023
@DonJayamanne DonJayamanne removed their assignment Sep 26, 2023
@DonJayamanne
Copy link
Contributor

Ok. I can see why complexity is 4, sure does take time, not really complicated but time consuming.
Works well, just as descrived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants