Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Turn on Remote Tunnel Access" should have a mode that installs as a service on the machine #184663

Closed
connor4312 opened this issue Jun 9, 2023 · 0 comments · Fixed by #187869
Closed

"Turn on Remote Tunnel Access" should have a mode that installs as a service on the machine #184663

connor4312 opened this issue Jun 9, 2023 · 0 comments · Fixed by #187869
Assignees
@connor4312
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
July 2023

Comments

@connor4312
Copy link
Member

Prereqs:
@connor4312 connor4312 added this to the June 2023 milestone Jun 9, 2023
@connor4312 connor4312 self-assigned this Jun 9, 2023
@kieferrm kieferrm mentioned this issue Jun 11, 2023
Closed
9 tasks
@connor4312 connor4312 modified the milestones: June 2023, July 2023 Jun 28, 2023
@kieferrm kieferrm mentioned this issue Jul 9, 2023
Closed
10 tasks
@connor4312 connor4312 mentioned this issue Jul 13, 2023
Merged
connor4312 added a commit that referenced this issue Jul 13, 2023
@connor4312
cli: allow installation as a service from the UI
22425c5 
- When turning on remote tunnel access, a quickpick is now shown asking
  users whether it should be installed as a service or just run in
	the session.
- Picking the service install will install the tunnel as a service on
  the machine, and start it.
- Turning off remote tunnel access will uninstall the service only if
  we were the ones to install it.
- This involved some refactoring to add extra state to the RemoteTunnelService.
  There's now a "mode" that includes the previous "session" and reflects
	the desired end state.
- I also did a cleanup with a `StreamSplitter` to ensure output of the
  CLI gets read line-by-line. This was depended upon by the remote tunnel
	service code, but it's not actually guaranteed.
- Changes in the CLI: allow setting the tunnel name while installing the
  service, and make both service un/installation and renames idempotent.

Closes #184663
connor4312 added a commit that referenced this issue Jul 13, 2023
@connor4312
cli: allow installation as a service from the UI
07dcbb9 
- When turning on remote tunnel access, a quickpick is now shown asking
  users whether it should be installed as a service or just run in
	the session.
- Picking the service install will install the tunnel as a service on
  the machine, and start it.
- Turning off remote tunnel access will uninstall the service only if
  we were the ones to install it.
- This involved some refactoring to add extra state to the RemoteTunnelService.
  There's now a "mode" that includes the previous "session" and reflects
	the desired end state.
- I also did a cleanup with a `StreamSplitter` to ensure output of the
  CLI gets read line-by-line. This was depended upon by the remote tunnel
	service code, but it's not actually guaranteed.
- Changes in the CLI: allow setting the tunnel name while installing the
  service, and make both service un/installation and renames idempotent.

Closes #184663
connor4312 added a commit that referenced this issue Jul 13, 2023
@connor4312
cli: allow installation as a service from the UI
c47fc6c 
- When turning on remote tunnel access, a quickpick is now shown asking
  users whether it should be installed as a service or just run in
	the session.
- Picking the service install will install the tunnel as a service on
  the machine, and start it.
- Turning off remote tunnel access will uninstall the service only if
  we were the ones to install it.
- This involved some refactoring to add extra state to the RemoteTunnelService.
  There's now a "mode" that includes the previous "session" and reflects
	the desired end state.
- I also did a cleanup with a `StreamSplitter` to ensure output of the
  CLI gets read line-by-line. This was depended upon by the remote tunnel
	service code, but it's not actually guaranteed.
- Changes in the CLI: allow setting the tunnel name while installing the
  service, and make both service un/installation and renames idempotent.

Closes #184663
connor4312 added a commit that referenced this issue Jul 14, 2023
@connor4312
cli: allow installation as a service from the UI (#187869)
12340da 
- When turning on remote tunnel access, a quickpick is now shown asking
  users whether it should be installed as a service or just run in
	the session.
- Picking the service install will install the tunnel as a service on
  the machine, and start it.
- Turning off remote tunnel access will uninstall the service only if
  we were the ones to install it.
- This involved some refactoring to add extra state to the RemoteTunnelService.
  There's now a "mode" that includes the previous "session" and reflects
	the desired end state.
- I also did a cleanup with a `StreamSplitter` to ensure output of the
  CLI gets read line-by-line. This was depended upon by the remote tunnel
	service code, but it's not actually guaranteed.
- Changes in the CLI: allow setting the tunnel name while installing the
  service, and make both service un/installation and renames idempotent.

Closes #184663
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

cli: allow installation as a service from the UI microsoft/vscode
2 participants
@connor4312 and others