Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunnel service log blocks the vscode update #183715

Closed
aeschli opened this issue May 29, 2023 · 0 comments · Fixed by #187738
Closed

tunnel service log blocks the vscode update #183715

aeschli opened this issue May 29, 2023 · 0 comments · Fixed by #187738
Assignees
@connor4312
Labels
insiders-released Patch has been released in VS Code Insiders remote-tunnel
Milestone
July 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented May 29, 2023 •
edited
Loading

Running tunnel service log can block the VS Code update on Windows as it prevents deleting the parent folder. The updater needs a way to terminate it, and a mutex to know that it needs to be terminated.
@aeschli aeschli changed the title tunnel service log should set a mutex tunnel service log blocks the vscode update May 29, 2023
@connor4312 connor4312 mentioned this issue Jun 9, 2023
Closed
@connor4312 connor4312 mentioned this issue Jul 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
insiders-released Patch has been released in VS Code Insiders remote-tunnel
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

cli: stop tunnel processes during update microsoft/vscode
3 participants
@connor4312 @aeschli and others