Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show terminal persistent sessions setting when searching for "history" #152087

Closed
miguelsolorio opened this issue Jun 14, 2022 · 9 comments · Fixed by #152114
Closed

Show terminal persistent sessions setting when searching for "history" #152087

miguelsolorio opened this issue Jun 14, 2022 · 9 comments · Fixed by #152114
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

I'm always returning to projects and see the terminal messages filled with the same repeated message and would like to clean them up and not be shown as I see no value in them for myself.

Current

CleanShot 2022-06-14 at 09 10 55@2x

Desired

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2022

This bugs me too, #142855 tracks only showing it once in this case by avoiding saving new parts if there is no terminal input, similar to how it only saves and restored in the first place if the terminal has been interacted with. I don't think we should be hiding the message all together as it's misleading what is part of this shell's session, command decorations would be broken for the ones that aren't part of this session (look like a bug) and it would show up like this which is a bit weird:

image

@Tyriar Tyriar closed this as completed Jun 14, 2022
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 14, 2022
@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Jun 14, 2022

Would it be possible to have an option to hide the previous session altogether and just show a new session? That would be a simple approach that would work for me personally, similar to debug.terminal.clearBeforeReusing

CleanShot 2022-06-14 at 09 40 18@2x

@meganrogge
Copy link
Contributor

@misolori you can just create a new terminal altogether by setting terminal.integrated.enablePersistentSessions to false

@miguelsolorio
Copy link
Contributor Author

@meganrogge thank you! I was searching for a setting and didn't ever find that one, kept looking for "terminal history" and "terminal clear"

@meganrogge
Copy link
Contributor

the name is definitely not discoverable. I wonder if we should change it @Tyriar

@miguelsolorio
Copy link
Contributor Author

or can we add any meta data or keywords to settings that will be picked up by search? cc @rzhao271

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2022

tags I guess?

/**
* List of tags associated to the property.
* - A tag can be used for filtering
* - Use `experimental` tag for marking the setting as experimental. **Note:** Defaults of experimental settings can be changed by the running experiments.
*/
tags?: string[];

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2022

Oh that doesn't work, @rzhao271 do we have a way to do search keywords?

@Tyriar Tyriar reopened this Jun 14, 2022
@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 14, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 14, 2022
@Tyriar Tyriar removed the *duplicate Issue identified as a duplicate of another issue(s) label Jun 14, 2022
@Tyriar Tyriar changed the title Provide option to disable terminal session restoration Show terminal persistent sessions setting when searching for "history" Jun 14, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2022

@misolori you actually want terminal.integrated.persistentSessionReviveProcess, the enablePersistentSessions setting will disable process reconnect across window reloads.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-persistence Relating to process reconnection or process revive and removed info-needed Issue requires more information from poster labels Jun 14, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 15, 2022
@meganrogge meganrogge added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants