Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session contents restored messages should not be shown when only shell integration activated message has been written to the terminal #142855

Closed
meganrogge opened this issue Feb 11, 2022 · 4 comments · Fixed by #152408
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive terminal-shell-integration Shell integration infrastructure, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

Screen Shot 2022-02-11 at 10 06 53 AM

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-persistence Relating to process reconnection or process revive terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Feb 11, 2022
@meganrogge meganrogge added this to the February 2022 milestone Feb 11, 2022
@meganrogge
Copy link
Contributor Author

meganrogge commented Feb 11, 2022

More broadly, I find myself clearing the terminals when I restart because the Session contents restored message makes the terminals look a bit busy/messy IMO. @Tyriar thoughts?

@Tyriar
Copy link
Member

Tyriar commented Feb 14, 2022

Not sure why this is happening as the message doesn't cause input, can reproduce though.

I find myself clearing the terminals when I restart because the Session contents restored message makes the terminals look a bit busy/messy IMO.

I restart them sometimes to get into a "clean state", the Terminal: Clear command would do something similar though. Are you proposing a different style or something?

@meganrogge
Copy link
Contributor Author

I use terminal clear. I'm proposing not showing them at all because that is what I'd prefer. Isn't it obvious that they're restored when they're restored?

I realize other terminals also show the session restored banner, but don't think it adds to the experience; in fact, it detracts from mine.

@Tyriar
Copy link
Member

Tyriar commented Feb 15, 2022

Discussed offline, to avoid this problem so it's less of an issue how loud the message is:

image

We could discard that middle section if the terminal has had no input so only the following would show after multiple reloads without terminal interaction:

Tyriar\xterm.js  master [?]
❯

 Session contents restored from 2/15/2022 at 7:39:34 AM 

Shell integration activated!

Tyriar\xterm.js  master [?] 
❯    

@Tyriar Tyriar added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Feb 25, 2022
@Tyriar Tyriar modified the milestones: February 2022, Backlog Feb 25, 2022
@Tyriar Tyriar modified the milestones: Backlog, June 2022 Jun 16, 2022
Tyriar added a commit that referenced this issue Jun 16, 2022
This makes terminals only restore their current session's buffer if
there was some interaction by the user, similar to how the initial
process doesn't get revived if no interaction occurred.

Fixes #142855
Tyriar added a commit that referenced this issue Jun 17, 2022
This makes terminals only restore their current session's buffer if
there was some interaction by the user, similar to how the initial
process doesn't get revived if no interaction occurred.

Fixes #142855
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 17, 2022
@rzhao271 rzhao271 added verified Verification succeeded verification-needed Verification of issue is requested and removed verified Verification succeeded labels Jun 28, 2022
@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Jun 29, 2022
@rzhao271 rzhao271 removed the verification-steps-needed Steps to verify are needed for verification label Jun 29, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive terminal-shell-integration Shell integration infrastructure, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants