Unit tests should be fast 🐎

[jrieken]

This is a continuation of #134972. A unit test shouldn't take longer than 50ms. An easy way to "speed up" setTimeout and friends is @hediet's runWithFakedTimers-utility

To reproduce these numbers

• run ./scripts/test.sh --reporter json > ~/Desktop/test_out.json
• open the file and remove the first non-json lines
• run jq '.tests | map(select(.duration > 50)) | sort_by(.duration) | [.[] | "- [ ] " + (.duration|tostring) + "ms, " + .fullTitle ]' ~/Desktop/test_out.json

tests slower than 50ms

• 51ms, MarkdownRenderer Code block renderer asyncRenderCallback should not be invoked if result is immediately disposed @mjbvz
• 104ms, MarkdownRenderer Code block renderer asyncRenderCallback should not be invoked if dispose is called before code block is rendered @mjbvz
• 55ms, ExtHostAuthentication Can get multiple sessions (with different scopes) in one extension @TylerLeonhardt
• 55ms, ExtHostAuthentication Can get multiple sessions (from different providers) in one extension @TylerLeonhardt
• 60ms, ExtHostAuthentication clearSessionPreference - true @TylerLeonhardt
• 72ms, ExtHostAuthentication silently getting session should return a session (if any) regardless of preference - fixes Using silent property on getSession for provider that supports multiple accounts could be more silent #137819 @TylerLeonhardt
• 93ms, Editor Controller issue Greater than 1000+ multi cursor typing replacement text appears inverted, lines begin to drop off selection. #23913: Greater than 1000+ multi cursor typing replacement text appears inverted, lines begin to drop off selection @alexdima
• 51ms, Notebook Find Update find matches basics 3 @rebornix
• 53ms, Notebook Find Update find matches basics @rebornix
• 51ms, Notebook Find Update find matches, Notebook find doesn't update #112748 @rebornix

[azuregogo]

Excellent في الجمعة، ١٢ يناير ٢٠٢٤، ٣:٢٧ ص Matt Bierner ***@***.***> كتب:

…

Closed #149712 <#149712> as completed via #202295 <#202295>. — Reply to this email directly, view it on GitHub <#149712 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBCJO2OE5AC7YNH7WS66DODYOCGPNAVCNFSM5WE6XADKU5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGE2DMMZSHE2DQMBS> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>