Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook find doesn't update #112748

Closed
jrieken opened this issue Dec 17, 2020 · 3 comments
Closed

Notebook find doesn't update #112748

jrieken opened this issue Dec 17, 2020 · 3 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook papercut 🩸 A particularly annoying issue impacting someone on the team polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 17, 2020

  • have MD cell with context below
  • search for "F8"
  • type while at the first match
  • use arrow keys to go to next match
  • 🐛 matches are off

Dec-17-2020 16-42-06

### Some markdown

Issue Type: <b>Bug</b>

Using a GH Issues notebook.

1) I have a notebook with multiple cells referencing a macro. Change the name of the macro so that all cells using it show an error.
2) F8 repeated
-> From time to time, cells that have the keyboard focus are not revealed correctly.
-> Sometime,dddd the F8 problem zone gets stuck. I.e. while the keyboard focus moves forward the cell with the F8 problem zone stays in place.
-> When scrolling a cell with a F8 problem zone out of sight and then F8 again, the two problems become severe.

VS Code version: Code - Insiders 1.46.0-insider (da3bf754c3c0eabda1dc80ed9d627679ee560697, 2020-05-19T10:04:14.981Z)
OS version: Darwin x64 18.7.0
Remote OS version: Linux x64 5.3.0-1020-azure

@rebornix rebornix added polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach labels Dec 21, 2020
@rebornix rebornix added this to the January 2021 milestone Dec 21, 2020
@rebornix
Copy link
Member

yup, auto search is not hooked up with it yet.

@jrieken jrieken added the papercut 🩸 A particularly annoying issue impacting someone on the team label Jan 21, 2021
@rebornix rebornix modified the milestones: January 2021, February 2021 Jan 28, 2021
@jrieken jrieken removed this from the February 2021 milestone Feb 17, 2021
@rebornix rebornix added this to the April 2021 milestone Apr 20, 2021
@rebornix
Copy link
Member

The code changes to fix this turns out to be a bit large, so push this to May considering it's endgame.

@rebornix rebornix modified the milestones: April 2021, May 2021 Apr 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook papercut 🩸 A particularly annoying issue impacting someone on the team polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants
@rebornix @jrieken and others