Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codespaces] icons of terminals are not preserved on reload #124359

Closed
JanKoehnlein opened this issue May 21, 2021 · 1 comment
Closed

[codespaces] icons of terminals are not preserved on reload #124359

JanKoehnlein opened this issue May 21, 2021 · 1 comment
Assignees
@Tyriar

Comments

@JanKoehnlein
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.56.2
  • OS Version: MacOSX, Chrome

Steps to Reproduce:

  1. In Codespaces, open a new terminal and switch on Show tabs
  2. Change icon / title of the terminal
  3. Reload the browser tab
    -> the tabs show as empty tree items, without icon and title

My suspicion: The IShellLaunchConfigDto lacks the icon property from IShellLaunchConfig, such that the remote backend cannot remember it. In addition, terminals with a config that has an undefined icon are shown as completely blank.
@JanKoehnlein JanKoehnlein mentioned this issue May 21, 2021
Closed
JanKoehnlein added a commit to gitpod-io/openvscode-server that referenced this issue May 21, 2021
@JanKoehnlein
[gitpod] use and persist proper terminal icons
565bc73 
Contains fix for upstream microsoft#124359

Fixes microsoft#4268
@JanKoehnlein JanKoehnlein mentioned this issue May 21, 2021
Closed
@Tyriar
Copy link
Member

Tyriar commented May 21, 2021

This works in main

@Tyriar Tyriar closed this as completed May 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanKoehnlein @Tyriar