Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] icons of terminals are not preserved on reload #4268

Closed
JanKoehnlein opened this issue May 21, 2021 · 1 comment · Fixed by #4507
Closed

[code] icons of terminals are not preserved on reload #4268

JanKoehnlein opened this issue May 21, 2021 · 1 comment · Fixed by #4507
Assignees
Labels

Comments

@JanKoehnlein
Copy link
Contributor

Bug description

See microsoft/vscode#124359

This issue is a reminder we should adapt our RemoteTerminalChannelServer to correctly pick up the terminal's icon and remember it once that's fixed in VS Code.

Steps to reproduce

  1. Open a new terminal and switch on Show tabs in the combo box to select the terminals
  2. Change icon / title of the terminal
  3. Reload the browser tab
    -> the tabs show as empty tree items, without icon and title

Expected behavior

Icon and title should be preserved.

Example repository

Any

Anything else?

No response

@JanKoehnlein
Copy link
Contributor Author

Should be fixed via #4403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants