Don't automatically forward debug ports in auto attach

[connor4312]

js-debug's auto attach "smart" mode causes a process to enter auto attach, without explicit flags. When entering debug mode, we let the OS choose a random free port (0) since we don't need any specific port.

I noticed when working in a remote container that this caused a bunch of ports to automatically be forwarded in the remote.

Unfortunately this message is printed by Node and I cannot always stop it from printing.

Is there any way we could exclude the pattern Debugger listening on ... from automatic forwarding?

[alexr00]

@connor4312 we can exclude based on "Debugger listening on", but are there cases where Node may print that message and it isn't coming form js-debug's auto attach? Is there some other information about the terminal or state in VS Code I can use to exclude that link?

[connor4312]

It will also be printed if running something like node --inspect manually. But I would venture to guess that in those cases people will probably be subsequently attaching with vscode, so forwarding would not be necessary since js-debug is a workspace extension.

If you wanted to hone in more specifically, you could include 127.0.0.1:9229, which is the default port --inspect listens on and auto attach will only use with a 1 in 65000-or-so chance.

[connor4312]

Thanks!

[roblourens]

I can't repro this in stable, and I don't see the notification when I trigger port forwarding another way, what am I missing?

[alexr00]

The notification is new this iteration, so no repro in stable. To verify:

• run command Remote-Containers: Try a sample...
• Choose the node sample
• Make sure debug auto attach is on (command Debug: Toggle Auto Attach -> choose Smart)
• In the integrated terminal run node server.js
• Verify that you don't see the port forwarded notification.

[roblourens]

I don't see it, but do I expect to see it in this case?

[alexr00]

That case should forward the port.