Fix bad dispose in automatic port forwarding (#108195)

Fixes #107243
microsoft · Oct 6, 2020 · b0231fd · b0231fd
1 parent 2ccf795
commit b0231fd
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/src/vs/workbench/contrib/remote/browser/remote.ts b/src/vs/workbench/contrib/remote/browser/remote.ts
@@ -841,7 +841,7 @@ class RemoteAgentConnectionStatusListener implements IWorkbenchContribution {
 }
 
 class AutomaticPortForwarding extends Disposable implements IWorkbenchContribution {
-	private contextServiceListener: IDisposable;
+	private contextServiceListener?: IDisposable;
 
 	constructor(
 		@ITerminalService private readonly terminalService: ITerminalService,
@@ -855,20 +855,23 @@ class AutomaticPortForwarding extends Disposable implements IWorkbenchContributi
 		super();
 		if (this.environmentService.configuration.remoteAuthority) {
 			this.startUrlFinder();
+		} else {
+			this.contextServiceListener = this._register(this.contextKeyService.onDidChangeContext(e => {
+				if (e.affectsSome(new Set(forwardedPortsViewEnabled.keys()))) {
+					this.startUrlFinder();
+				}
+			}));
 		}
-		this.contextServiceListener = this._register(this.contextKeyService.onDidChangeContext(e => {
-			if (e.affectsSome(new Set(forwardedPortsViewEnabled.keys()))) {
-				this.startUrlFinder();
-			}
-		}));
 	}
 
 	private isStarted = false;
 	private startUrlFinder() {
 		if (!this.isStarted && !forwardedPortsViewEnabled.getValue(this.contextKeyService)) {
 			return;
 		}
-		this.contextServiceListener.dispose();
+		if (this.contextServiceListener) {
+			this.contextServiceListener.dispose();
+		}
 		this.isStarted = true;
 		const urlFinder = this._register(new UrlFinder(this.terminalService));
 		this._register(urlFinder.onDidMatchLocalUrl(async (localUrl) => {