Trusted Types compatibility: Make VSCode TrustedTypes compliant #103699

annkamsk · 2020-07-31T12:44:00Z

Hi, I’m Anna, working as an intern on the Google Security team this summer. I’m working on a project that’s part of the larger effort to harden popular open-source libraries against web vulnerabilities.

Following up on an email exchange with @egamma and @jrieken, we’re planning to add Trusted Types to VSCode’s codebase.

What are Trusted Types

DOM-based cross-site scripting (DOM XSS) is one of the most common web security vulnerabilities, and it's very easy to introduce it in your application.

Trusted Types give you the tools to write, security review, and maintain applications free of DOM XSS vulnerabilities by making the dangerous web API functions secure by default. Trusted Types are supported in Chrome since version 83. For more information see https://web.dev/trusted-types/

Why make VSCode compliant with Trusted Types?

Having dealt with large JS/TS codebases, we (the Google ISE team) noticed that while correctly escaping the data is relatively easy - what is hard is assuring that this is done comprehensively. For example, that all "scripty" sinks in innerHTML are covered, and that the escaping is done every time the data reaches them. That's where Trusted Types help tremendously. In our estimations, Trusted Types might effectively kill XSS for serverless applications.

VSCode is a large codebase running in a very sensitive application, having the assurance that it is free of XSS seems like a worthy goal.

Approximate cost of the effort

After running a static analysis pass for Trusted Types compliance on VSCode, I discovered 103 potential issues, ranging from trivial refactorings (assigning non-html literal strings to innerHTML, ~45% of issues) to much more complex cases (building arbitrary html).
I’m planning to start fixing the simplest ones that can be changed without creating a Trusted Types Policy and then take on less trivial problems. Each change will group issues with similar causes and be tracked by a separate more specific github issue.

You can perform the check for Trusted Types compliance on VSCode yourself by running this fork of the VSCode, where I added a script that does exactly that.

Edit: Tagging @engelsdamien and @koto for visibility

engelsdamien · 2020-08-05T10:44:31Z

Hi there, @koto and myself are mentoring Anna for this project.

Please let us know if there is any process you'd like us to follow for PRs (in addition to the normal contribution guidelines)

jrieken · 2020-08-17T13:48:27Z

@annkamsk Thanks so far. I went through the usages of innerHTML and to make it simpler for us to assign and review PRs I suggest the following plan

Lots of innerHTML-use is coming from renderCodicons. We should have an equivalent that returns elements instead of a string and adopt it. Given this will be a uniform adoption it's OK to put this into a single PR.
Another common innerHTML-use is updating style elements, like this. This is part of our theming story and I believe usages can be replaced with textContent. This should also be a relatively uniform change and OK to have in a single PR.
Other innerHTML-use. Since these changes will require more review it's best to create more fine grained PRs so that owners can do the review. A good rule of thumb would a PR per feature folder, like 'breadcrumbs' or 'codelens'.

Unfortunately, the last item means a little more overhead. An alternative (and that's how we have often done such changes in the past) is to create and manage a list of pending adoptions and to assign people to fix them. That guarantees a broad understanding of the issue since the whole team will be involved. Generally, the team is happy to make those changes but it needs some tool to discover invalid innerHTML-usages (I have been using TypeScript reference search).

#HappyCoding

engelsdamien · 2020-08-28T12:53:03Z

Hey @jrieken thanks for the responsiveness.

We are currently working on releasing tsec on npm so we can add it as a runnable target in you package.json's scripts. As soon as this is done, @annkamsk will send a PR so that it becomes easy to run tsec at head.

Note that tsec is still under developpement and we are still fixing bugs in it, so it might miss some things for now.
Long term, tsec will also probably get deprecated in favor of something that is more developper friendly to give warnings & suggested fixes directly in the editor. (@uraj can probably give more details.)

Cheers

Damien

jrieken · 2020-08-28T13:06:24Z

Thanks for the heads-up. We will prepare the August release next week and after that we'll enter "debt week". Having some workable version by then would be the best because folks are in clean-up-mode and can tackle violations by themselves.

annkamsk · 2020-09-15T13:29:31Z

Hi @jrieken,
I've seen that the VSCode team already fixed a significant number of issues, which is really exciting. To make the expectations clear, would you prefer to collect and solve the rest of the TT violations within your team or would our PRs be still welcome? Either way, I'd be more than happy to provide support.
If you considered it helpful, I could work on eg. builders for TT policy, so that your team can quickly adapt the code to them.

I'm attaching also a current list of violations that I haven't seen mentioned in already existing issues. Some of them require use of the policy.

innerHTML

setAttribute

src/vs/loader.js:701

Workers

src/vs/base/worker/defaultWorkerFactory.ts:16:15
src/vs/base/worker/defaultWorkerFactory.ts:24:14
src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts:177:22
src/vs/workbench/services/extensions/worker/extensionHostWorker.ts:50:18
src/vs/workbench/services/extensions/worker/extensionHostWorker.ts:51:2

Imports

src/vs/workbench/services/extensions/worker/extensionHostWorkerMain.ts:12

DOMParser.parseFromString

src/vs/workbench/contrib/extensions/browser/extensionEditor.ts:64
src/vs/workbench/contrib/webview/browser/pre/main.js:370

engelsdamien · 2020-09-23T09:26:14Z

@jrieken any updates on this?

We don't have clear visibility on which issues the VSCode team is planning on fixing & we would like to avoid duplicating work.

Is it safe to assume that the issue outlined above by annkamsk@ are not being worked on by anyone?

jrieken · 2020-09-24T07:26:35Z

Sorry! This somehow got lost... We still have #106395 for some violation cleanup. I can ping folks directly to see if a potential conflict is about to happen - tho it unlikely as this is treated as debt work for of us and that's usually tackled during the first week in the milestone (roughly the first week in the month). So, yeah more PRs are definitely welcome.

We also have #106396 which is about using policies. For that there is some more work on my plate and we should re-focus the discussion from the amd-loader (which is some scenarios like gh-codespaces not in our control or for desktop not used like that) to simpler cases, like markdown-rendering or line-rendering of the editor itself.

engelsdamien · 2020-09-24T14:31:49Z

Thanks for the update @jrieken

@annkamsk is getting close to the end of her internship, but she will focus on the changes I proposed in #106396 (comment) for now and leave most of the remaining innerHTML issues to the VSCode team.

If time permits, we will pick up another issue from non-innerHTML ones above.

jrieken · 2020-09-24T14:45:55Z

@annkamsk is getting close to the end of her internship, but she will focus on the changes I proposed in #106396 (comment) for now and leave most of the remaining innerHTML issues to the VSCode team.

That makes sense. I like the loader changes you have proposed (and I should probably comment on that issue) but I didn't have enough time to think/understand everything. One thing is that the loader creates many new urls, e.g when asynchronously importing more modules, so it does need to know how to create a trusted url from to strings.

fyi - this is the loader repo and where the urls are set: https://github.com/microsoft/vscode-loader/blob/f7c06bec703d9ff0ea8864a066bf5b8294275703/src/core/scriptLoader.ts#L215

Siegrift · 2020-10-09T10:37:33Z

Hi @jrieken , most of the changes to tsec regarding Trusted Types are merged internally and we would like to release them at the beginning of the next week. I will try to test whether the changes won't cause regressions for your project, but I am fairly confident there shouldn't be any. In case you notice any problems feel free to create an issue in https://github.com/googleinterns/tsec (to avoid spamming this thread).

Notable changes:

All of the sinks accepting a string now accept a form of Trusted Type. Due to TS limitation you need to use workarounds when using TT in the sinks. We offer a few alternatives, which will be documented in README.md once we release the new version.
Implemented a TS language service plugin, which you can configure to show the violations directly in the IDE.
There have been small enhancements to the checker and we are able to catch more violating patterns (e.g. window[eval](someString))
Added new rule for banning the use of dynamic imports (currently this one doesn't support TT)

…t tags, #103699

#103699

jrieken · 2021-01-07T16:40:33Z

fyi - I have just pushed a commit that enables trusted types for tomorrows insiders build 🥳

Things that are still to be done:

perform a thorough review of our policy usages
we have a default policy which we use instead of exploding in the face our users. After gaining more confidence we should make this more strict
we also have a legit usage of the default policy because of an electron issue ([Feature Request]: Enable w3c trusted types usage with electron apps electron/electron#27211), tho that usage is quite strict. Maybe @Siegrift or @engelsdamien can advise
I don't think tsec is ready to be part of our build pipeline. there is still TS trouble, the inability to ignore policy usage errors, and differences between tsec and chromiums actual behaviour.

koto · 2021-01-07T17:22:08Z

That's awesome! I'm super excited about that!

We've seen default policies like that one, it seems very expected during the migration. The only alternative for upstream Electron is to I guess use the DOM APIs for the initial HTML, I'll look into the Electron issue directly.

From our experience, the static checks (so tsec) worked better, but of course internally tsec is part of a bigger pipeline tied to our build system, so we don't have many of the integration problems you're facing. We're constantly working on improving tsec, such that it will eventually be ready to integrate, please keep filing bugs and nagging us if we don't fix them ;)

koto · 2021-01-08T09:25:46Z

Can you check on your end if koto/electron@02d0fd0 addresses the Electron issue? My environment seems to have some issues building Electron now...

koto · 2021-01-12T13:18:28Z

@jrieken what's the easiest way to reproduce the default policy call caused by Electron? I yarn run compiled vscode, followed by ./scripts/code.sh.

I see the default policy installed on the Code window, but don't see it being called yet - I tried opening a folder, Terminal window, clicking on the links in the landing page, editing files etc.

jrieken · 2021-01-12T13:41:31Z

I see the default policy installed on the Code window, but don't see it being called yet

Either go "Extensions Viewlet > Select any extension so that its extension editor shows" or alternatively create a test.md file, edit its source and then trigger preview from the editor tool bar

jrieken · 2021-01-12T13:42:24Z

Can you check on your end if koto/electron@02d0fd0 addresses the Electron issue? My environment seems to have some issues building Electron now...

Sorry, didn't reply here. We actually don't build electron in our machine. Looping in @deepak1556 in case he can help with koto/electron@02d0fd0

engelsdamien · 2021-01-28T09:16:38Z

Hey @jrieken,

Thanks for your patience, I have some updates about how we can reduce and review the use of policies.

We just released a library to help with this called "safevalues" (github, npm). It contains:

safe-by-construction builder APIs
helpers to assign to DOM sinks without having to use casts
utilities to help refactor legacy code & encode patterns not supported by the safe by construction APIs above

My plan to improve the current situation is to do the following:

Add all current tsec violations to src/tsec.exemptions.json explicitly. This make the tsec-compile-check script stop outputting violations (including the current false positives), but also force any new code that introduce a violation to have to modify the exemptions list, which should prevent new violations. I think this is what you need to start including tsec in your build/CI pipeline.
Move all the current policy usages to use "legacy" conversions, which should get rid of all the TrustedHTML|string types in favor of pure TrustedHTML as well as fix all of the sink assignments. We are working on a tsec release to also track usage of these functions & they will be tracked in the excemption list as any other violation.
Incrementally move the "legacy" conversions to callers, until they reach the place where values are produces / mutated at which point they will be either refactored into on of the safe-by-construction builders or use a "reviewed" conversion, which includes an explanation of why the code is safe as part of the API.
The final state should be that tsec's exemption list only contains a few references to these "reviewed" conversions, which fully encode the security sensitive surface of VSCode & are easy to review for a human.

My questions for you are:

Does this sound like a reasonable plan ? I have a working proof of concept for points 1 & 2 above if you want to see what it would look like.
Are there some restrictions in VSCode that would prevent you from depending on safevalues ? When creating the proof of concept above, I ran into a linter check complaining that my imports didn't start with 'vs/'
Do you have experience with GitHub's code owners mechanism ? It would be beneficial to restrict who can edit / needs to review changes to tsec's exemption list to ensure that the "reviewed" conversions are used properly.

jrieken · 2021-02-02T11:40:22Z

Does this sound like a reasonable plan ? I have a working proof of concept for points 1 & 2 above if you want to see what it would look like.

Yes - I like where this is going. The changes to the src/tsec.exemptions.json list is very welcome as well.

Are there some restrictions in VSCode that would prevent you from depending on safevalues ? When creating the proof of concept above, I ran into a linter check complaining that my imports didn't start with 'vs/'

I am afraid that's a little complicated. Everything in the common-, browser-, and editor-layer is also shipped with the monaco editor and due to bundling challenges we only allow files from within those folders. We solve this by coping dependencies into our source tree (and we then re-export them). The marked-js and insane usages are samples for this, see src/vs/base/common/marked. We would do something similar with safevalues, likely bundle it first. Depending on how often safevalues is going to change this should be manageable.

Do you have experience with GitHub's code owners mechanism ? It would be beneficial to restrict who can edit / needs to review changes to tsec's exemption list to ensure that the "reviewed" conversions are used properly.

We have actually not used that. We are a relatively small and close team and so far things have worked out for us. I need to take a look first and then would propose this to the team first.

engelsdamien · 2021-02-02T12:50:41Z

Awesome, thanks for the feedback, you should start receiving PRs by the end of the week then.

I am afraid that's a little complicated. Everything in the common-, browser-, and editor-layer is also shipped with the monaco editor and due to bundling challenges we only allow files from within those folders. We solve this by coping dependencies into our source tree (and we then re-export them). The marked-js and insane usages are samples for this, see src/vs/base/common/marked. We would do something similar with safevalues, likely bundle it first. Depending on how often safevalues is going to change this should be manageable.

No worries, this also has the positive side effect that you get tsec checking dependencies for free.

Do you have a script that can pull in the dependencies automatically, or is this a manual process ? If so I will just try to match what marked and insane are doing.

jrieken · 2021-02-02T17:35:27Z

Do you have a script that can pull in the dependencies automatically, or is this a manual process

All manual... Since safevalues is using dom API it should be living inside vs/base/browser. Best would be if it can be compiled into AMD or UMD so that we easily load it - otherwise would need to massage it a little.

622cb03f7e0 Merge pull request #116444 from microsoft/alex/stable-fix-116060 5933e313e5d Fixes #116060: Clone minimap options before changing them f3a12e053e1 Pick up TS 4.1.5 (#116380) 3b9cef2b8d1 Bump Emmet (#116230) 8757f67bcda fix #116049 (#116319) 73c0a56bbd2 Merge pull request #116311 from microsoft/joh/fix/116094 5cf34afa107 Use weak shell quoting for npm tasks with -- (#116309) 6635ca9a64e Merge pull request #116245 from microsoft/connor4312/debug-repl-fix 65406fcea58 fix https://github.com/microsoft/vscode/issues/116094 43e11faf4ee fix: CreateFile ERROR_FILE_NOT_FOUND from crashpad handler (#116256) 17d65083f6c debug: replace element when appending text to ensure updates in repl 9d194eac0d7 This reverts us to the previous distro commit (#116218) 1fe57f42761 Merge pull request #115789 from microsoft/rebornix/fix-notebook-runstate d63ab6acdbd bump version to 1.53.2 (#116228) 4aff7304539 Merge pull request #115772 from microsoft/misolori/1.53/create-pr-icon 678843ff3ad fixes #115810 (#115943) e1ec11f5183 always fallback to plain text (#115860) (#116177) 615ea78d96a status - update background color (#115886) (#116181) 00d7f953055 add changes (#116223) 3c19fc731cb Pick up the official TS 4.1.4 build (#116222) 5d424b828ad Pick up new distro version and bump version (#116149) ee2c947e064 ci: update newer 11.2.1 for CVE-2021-21148 (#115951) e23884b9476 re #115717 5da053f081f Update Codicons: add 'git-pull-request-create' https://github.com/microsoft/vscode-codicons/commit/686357b7174e7b3113640fea20db7efc84d8d1d4 7f04ecd68be use PersistKeySet (#115744) 8490d3dde47 Merge pull request #115701 from microsoft/sandy081/fix115699 1d6c8826375 Fix #115699 f84decb78f3 Merge pull request #115686 from microsoft/isidorn/openEditorsCollapsed 203b86d14c5 fixes 115685 83f7a99bd95 Azure DevOps - Add global variable for VSCODE_QUALITY (#115636) (#115673) e1c818a1711 Merge pull request #115655 from microsoft/rebornix/fix-jupyter-activation 761dd469c13 chore: bump distro 8d779a4fada Merge pull request #115609 from microsoft/joh/fix115353 30fe91131c9 Merge pull request #115611 from microsoft/isidorn/selectForCompareUntitled 8dbf3d717b2 Revert do not show compare for markdown preivew bc38ed1b5a3 fix https://github.com/microsoft/vscode/issues/115353 65006668d07 Merge pull request #115547 from microsoft/aeschli/installProductIconTheme b99487f4168 Fix keybinding for Search view missing from view and sidebar (#115558) feda473d978 Enable 'Install Additional Product Icon Themes' 565dc9704f2 Use label as tooltip fallback properly (#115537) c02643e3c95 Properly set port label from ports attributes ae05392454a Merge pull request #115536 from microsoft/isidorn/debugConsoleCheckmark e4a65573a89 render "Debug Console" action after a separator a62c65bdb74 ignore focus when toggling debug console visibility 4d98741552d debug: do not render checkmark in view menu for the debug console ad232b0ac13 Fix #115509, register a separate action for opening serch editor from view (#115514) 4eb39372949 Fix #115511 Search Mode setting does not open editors unless search view is visible (#115513) 861a88ebadb Fixes #114201 da2adf433d8 Fixes microsoft/monaco-editor#2327 52f437953d5 add my paper cuts 090200d5aea fix https://github.com/microsoft/vscode/issues/115402 b36f9993162 Revert "fixes #114908" 99c406699ff fix mixed cells 384ef202510 :up: vscode-gulp-watch (fixes high CPU on Apple SI) e5b02b0610c liberate papercut usages 5a52bc29d5e Update working for default external opener d27b3130d92 Center notebook actions (run, stop, renderer, collapse, etc.) fixes #115087 38783a261a6 update version 36cabc4c123 🕺 One more time (refs #114219) 9934dea6888 Fixes microsoft/monaco-editor#2175: Improve hit testing code on FF 9d9aebd2e64 Add vscode-emmet-helper and restrict some labels 76adcde8743 Add `onDidChangeMarkers` (fixes microsoft/monaco-editor#313) de3b3ac5496 Don't exclude all unless there are no includes at all 791930308f0 Fixes microsoft/monaco-editor#2171 29c5c523023 Also apply #114709 to the extension editor 8c5e805d3a5 Fix spelling 662a698ef9e Skip failing test #115244 4d0a3637f29 Fix #115318: Getting started "Tweak My Settings" resets the getting started page f54b4fe5771 Fixes microsoft/monaco-editor#2168 d7821d5fb05 Remove console log ed4bd04c904 add other duplicate label to my endgame notebook 3fe4b0eb2f7 fix #115293, #113933 a7c0b43e1b5 Fix notebook action descriptions d045bc6ed1d Update color name for 'notebook.inactiveFocusCellBorder' (refs #114219) 660d6b82f85 Use unix style paths in includes always 4a338fd0d44 Merge pull request #115269 from microsoft/misolori/notebook-inactive-focus 588c3c49509 Merge branch 'master' into misolori/notebook-inactive-focus 12b56d878be Update color token name 'notebook.inactiveFocusedCellBorder' => 'notebook.inactiveFocus' 7ce63bef177 fix #115290 cbcfaa00f45 fixes #114914 8e22ecf4c85 fic unnecessary import e86befc8a9f Status bar: setting invalid color sets opacity 100%. Fixes #115292 b8bff49c9ae update distro 33e804f211f update milestone 3b87c36e2dc fix https://github.com/microsoft/vscode/issues/115207 631802d5cec comment out arm snaps 8aab6bc62d7 fixes #115219 3da57861612 fixes #114908 bb226913c5f Fix #115240 c8a90a48267 Merge pull request #115302 from microsoft/sandy081/remoteCLI b2a34770f01 #115294 also handle medium exe tip 724888adc76 Fix #115294 05568474922 remote cli: show host label f10dc2a548e more polish 4d3b15fda09 make sure to cancel continuation of `_handleEditorChanged`, related to https://github.com/microsoft/vscode/issues/115219, fyi @joaomoreno 971fa2cc9c6 Fixes #115304 0a943766a5f Fix monaco checks 9545d582360 Do not use the global `monaco` inside the editor bb841e3bbee fix https://github.com/microsoft/vscode/issues/115301 2ce26643d85 have a separate setting code cells in breadcrumbs, hide code cells in outline by default 17c617039b1 Squashed commit of the following: 3a287ee1eae Fixes microsoft/monaco-editor#2302: Only define global monaco if asked to do so or if using AMD a2bcb0608f1 fixes #114804 9519a5cb5a5 :lipstick: clean nuget.config file dcf0c56a796 [email protected] 1d15b2fe17a use final DAP spec 1.44 6be5904d199 polish 1c1df3eaee5 fix #115050 flickering tabs when wrapped (#115273) bb931908832 fixes #113703 5d63134de9e web - fix compile 4b5a9c4b5f0 change remote cli to manage only remtoe 19cbd870aaf web api - expose env as API from facade (#115295) ee4516a4851 always on trusted-types for yarn web, fyi @bpasero 03902d48417 Revert "fix #113933." 70de88696c0 d'oh, forgot to adjust anyScore to new data format of FuzzyScore, fixes https://github.com/microsoft/vscode/issues/115250 7a9e56510d2 Not requiring NPM for typings (fixes #115228) fb5bc5dd2ce fix typo: ResourcEditorInput → ResourceEditorInput (#115208) f73c011ae3f fix: disable rosetta option for universal build (#115280) ee7e0ad0933 fix #115107. 5e5f2f3b6ba feat: add identifier for universal app in issue reporter and about dialog (#115277) d42bed7957a fix #113933. d09508d9cb8 re #115012. e48b3d3cad5 Update codespace-related getting started images & wording 64c4f7f49c8 feature insights for notebook. 5aac4f44562 fixes #115267 014aaa1047f Fix #115271: Search in Open Editors triggers errors when done without files 848896a75eb update distro 98da2b151c1 Remove unused variable dfb86c5fa13 Add 'notebook.inactiveFocusedCellBorder' color token b1ba0c70eaf Fixes #114172: adopt latest loader 4febf1e6c38 Add missing class to fix view items For microsoft/vssaas-planning#2286 4378b7f0201 fix #115169. e6d5a209440 Fixes `getBranch` when name is fully qualified ba428fe1029 fix #114225. ed8043effb7 Save only open editors toggle state 8dcebbaf54f path => fsPath again 949a20d14f7 Merge pull request #115253 from microsoft:jackson/open-editors-fix 20f8e59d696 fixes #112347 a1bdcf6aed3 fixes #115121 3d66ab98eb9 path => fsPath e3b0eae7403 Test fix for #114795 22960ca0155 fixes #115073 e375d137174 fixes #114869 cdbc22a9cbd Fix #115234: Cannot view search results when one is in an Untitled editor 977b2f6a1ca fix https://github.com/microsoft/vscode/issues/115201 ff27ea9437d Fixes #115148: Indent new line when using `IndentOutdent` and `appendText` e4f1833d79b Use x64 node for darwin-arm64. Fixes #115009 96fa81bb74a Forward arguments when click is invoked via `makeContextAwareClickHandler` (fixes #115026) 4bd2d367e7c Remote smoketest timeout (fixes #115159) e4022fb0e27 Expose a `TestCodeEditor` that could be used by the workbench tests 030c9d52233 cap notebook outline elements at 64 characters, fixes https://github.com/microsoft/vscode/issues/115199 ee65f21c4f7 use marked lexer to find headings, render MD as plain text before, fixes https://github.com/microsoft/vscode/issues/115205, fixes https://github.com/microsoft/vscode/issues/115206, fixes https://github.com/microsoft/vscode/issues/115118 c789c22efa7 Fixes #115224: Adopt Trusted Types in DiffReview a552ebc1f8b Revert "diffReview: use insertAdajentText instead of insertAdjacentHTML" eb1cf4b0bae diffReview: use insertAdajentText instead of insertAdjacentHTML e06ef891b70 Fix #114379 096d70ce18e fixes #114990 35c5689d292 fixes #114914 0f59f684a1a Fix #114982 bb6014df3b4 tabs - let the overflow gradient not draw over borders (#115129) 676e8d62a3e chore: remove universal build from its separate stage (#115203) 99e7aea4a82 PR template - remove pull requests link full stop (#115090) c246b5704f7 fix https://github.com/microsoft/vscode/issues/115124 7b0cfdd04ad fix git askpass 93830fbe3d2 cleanup #113562 8e68e0c4331 log source f434f853aaf pfs - workaround broken reparse points on windows (fix #115113) 1718be68d0f Fallback to default opener when selected 5662b3b6a25 Log exceptions and continue in calls to ExternalOpener.canOpen 9ee751e859d Error if registering an unsupported scheme for external opener 9421e50aa8e Improve documentation for ExternalUriOpenerPriority c4c5f45ce0e fix #115150. 39d9b04f2c3 re #115018. a56bc0c6711 Don't write preferredLocation into workspace settings for find file references 0ede5243261 Reword multiple external opener error e5c4f426fee Fix setting decription and remove unused setting d9e4f5cf97b Add new icon for open editors view 005db8394c4 throw an error with a clear message when a notebook document is missing, https://github.com/microsoft/vscode/issues/115018 0a0537961c7 tree: do not break fully when you can not collapse an unexisting node bdd2f1628e2 callStack view: set callStackItemType context properly b7e87c1bf27 :lipstick: 9788e81e98d Log individual events because `extensionIds` gets clamped sometimes d5bdb0efb21 fix #115011. c3746fa0aed Fixes #114983 21e970473c3 Fixes #114998: Fall back to a document range semantic tokens provider 58624bfcb16 Fixes #115032: Add description db92af7429d Fixes #115033: respect indent action when using appendText 774f887a985 update notebook 578e2dc4ee7 Fixes #115026: Adopt `KeyboardEvent.triggeredByAccelerator` c1afd7c238b Add `_debugComposition` flag 9e07bfd5946 related to #115037 75ff8b11310 fixes #115037 1f1ed78f7db Use ;; instead of ; for line comments (#115036) 960a93f0e2e add unit test for #114971 09ef3735975 Merge pull request #114972 from enagic/master 371629106b3 #114031 fix user data sync tests 08a2f9c5e36 fix enablement handler 0540478dc72 Reduce getting started for codespaces 1a9dd758530 Don't error out on unknown provider. 25f6e3e2540 debug: update js-debug a331c2b515e Revert test changes 684459c8dc6 Refactor searching in open editors logic 17685a9db95 fix #108950. a46fd0ee934 fix: update `isUri()` to compare `fsPath` as `string` 8fa1417e309 run oss too 1.53, update distro 88af66bceed testing: accessibility round 2 500d514ecfa Add fall back to default option for when external uri opener fails 8b1feaed3e6 Documentation clean up for ExternalUriOpener 0e5b47fa43c Use object instead of array for `workbench.externalUriOpeners` ed98eb19685 Fix spelling ae8bd3216f0 :guard: tests for selecting kernel. 2f6c928b209 Fixes `getBranch` issue with remote branches Improves perf by reducing git calls from 3 to 1 748b2e5a854 Remove `#` from typescript deprecation warnings (#114787) 60f3919b26a fix #114959. 7e3d5a0ce0f fix #114048. do not update active kernel if kernel is executed. c7cf663d0c4 fix #106362. Keep runstate when undo/redo cell. b112052169c fix #114171 8d7740fe3b3 Merge pull request #114944 from microsoft/merogge/integration fd1ba8c9692 chore: bump [email protected] 2433b0eaf3c update distro f21a3b95e6a Merge pull request #114854 from susiwen8/hover-scroll a3131249625 update distro 58e88ff3ac0 testing: accessibility in explorer round 1 72172ed06c6 Merge branch 'master' into hover-scroll 68b7e79867e fix test-product icon 89e152635ab Limit spin to sync and loading (for #112298) 4ae47297a3e Merge branch 'master' into merogge/integration bd7dff7f071 testing: add test result to proposed api, ids for correlation ff08b2509f6 testing: fix not subscribing to first open workspace document cb69f5c9bca testing: add line background decorations 582ea371c2b [microsoft-authentication] Extend authentication session to return id tokens (#114675) 5a3fedf0c45 Merge pull request #114628 from microsoft/alex/python-language-configuration dac8d916d56 fix #110936 62093ff022b [html/json/css] update services & dependencies d877e86bdd3 Merge branch 'master' into alex/python-language-configuration e451364da15 Update Codicons version 51d19635946 reset template display when switching models. b18634fe902 fix #111587 Apply enablement to command links in welcome views (#113841) 07c3e907eb6 Improve glob module to support OS separator agnostic matching (#114810) 7468a060129 Revert "fix #114171." c708e3d5cf0 Move `workbench.startupEditor` to RESOURCE settings to allow setting to gettingStarted on a per repo basis Make sure to disallow setting to readme via workspace settings to prevent tracking attempts. 644d108f0d9 Do not reveal `FindOptionsWidget` all the time (fixes #114630) f3136a25fab Merge pull request #114934 from microsoft/merogge/terminalDimensions 60bce0f6287 feat: add macos universal build ci config (#114446) 19d87449a7b Add option to override 'pinned' when setting list selection Fix #114651 88fd9d9d178 fix #107239, set terminal dimensions d21d85a3fc2 Fix precommit hook on Windows c79a0282da3 Fixes microsoft/monaco-editor#2301 95227b3e10d Fixes microsoft/monaco-editor#2311 bf93e45b9c6 files - document file modes we use 1eb89d7da18 Add telemetry in the area of reconnection 3b03189afae Restore extensions in core (#114921) 5fcd9f74845 update distro 1aa795f2ff1 update jsdoc for #114908 415398e3995 tests - only use 'junction' for folders 604e231d371 fix strictEqual problem 7a89df95922 some more strict asserting tests 3cb3624be97 fix build b2242cc5ebf rename notebook outline settings to `notebook.outline.showCodeCells` fa7d5e7def0 fix `breadcrumbs.symbolPath` setting 830a7589e2a tests - enable symlink tests for windows again via 'junction' that do not require admin privilges 14cc5263711 Cannot open a remote workspace via --remote syntax. Fixes #114900 e60e0eab352 Cleanup some file related unit tests (#114895) a38cc82a154 fix mock, fixes tests 5592ed02fb3 rsource -> resource (#114837) bc3a770b78e perf - suggest status shouldn't listen when hidden dcda88e5a69 fix https://github.com/microsoft/vscode/issues/114798 eb5f9becd90 make SubmenuEntryActionViewItem not eagerly fetch/create the actual actions 137b6f5a464 Update endgame notebooks da0a04fffb9 Copy function fails over dangling symbolic links (fix #111621) c8ff3471b59 Do not attempt to open a workspace/folder that no longer exists when reloading window (fix #110982) d2cbc66835f Add empty problem matchers to build tasks so they don't ask me questions 1f8b429635d chore: custom protocols will also be intercepted by webRequest 62fcf3cce7e chore: cleanup webrequest filter for svg files 228459cc63a Fix: show hover when mouse control hover scroll 79be0a07248 Fix #114794 7b317afd931 Fix starting scroll for URIs with fragment (#111126) 98ec233c77e Fix: release note don't use editor style (#114709) e91fd3bd40b Updated Getting Started images with transparency instead of blur f0bd7eee100 only create processEnvironment once, now tests pass Co-authored by: Daniel Imms <[email protected]> 4300e6c7d2c Fix #105177 get terminal environment variable to show up in remote container a095d7fcf74 Make sure altClickMovesCursor gets refreshed c2d09aaeac1 Open Language Mode picker for new file (fixes #110330) 885e66edf9e Open Language Mode picker for new file (fixes #110330) cd6fa35fb94 fix #114233. add5b32d959 testing: initial implementation of test decorations 3e55989cca8 testing: move test filter to action bar 2c19f7fb988 Fix #105177 get terminal environment variable to show up in remote co… (#114721) d8a3c5f61c8 fix integration tests. 88d66caf686 fix #114782 ed72c64b87e Remove unused constant de11a7dec60 Rename `isEdge` to `isEdgeLegacy` (see https://support.microsoft.com/en-us/help/4533505/what-is-microsoft-edge-legacy) 007f704eaa9 Remove IME special cases for Edge Legacy 4fac328d03d ok I'm out 86d96faaaf8 extract menu entry view item creation logic, fyi @joaomoreno prep for https://github.com/microsoft/vscode/issues/114123 bd929b33de6 logging - put storage tracing behind a flag to reduce spam b9c67304807 add some docs for workaround for #114227 a07327a430d better default for PeekViewWidget#_getActionBarOptions 3f3b4136060 maybe this is it 4b7f41a732e Merge pull request #114544 from microsoft/aeschli/114542 67c9ab0d514 test all extensions if system/builtin a4a9a5e69db debt - use css variables instead of dynamically injected style sheets 534d5b08948 :lipstick: 89855f0fcdb web - editor context menu sometimes wrong (#109166) 7bb55c99943 Merge pull request #112169 from chenjigeng/fix/debug-auto-decode-link da48ddc5fea upgrade gulp-atom-electron b57017797cf debt - adopt some strictEqual in tests f123c904b17 remote cli: do not sync installed extensions 5809e9eb031 testresolver: support server extensions dcc1e9df991 workspaces - shuffle some code around b3807b04f22 Merge branch 'master' into fix/debug-auto-decode-link ebf351d04b3 workspaces code cleanup 4937aee5ed5 repl: on debugConsole.wordWrap change recreate the tree, do not require a restart 1e0f94f9009 Fixes #114468 6f9c818900d :lipstick: 0d8ec8f09fe Ports attributes open -> openBrowser 1be6d22ebca add setting `outline.showNotebookCodeCells` to control if code cells should show or not 37c162ed6df revert 37a4b96ae18 simplify FuzzyScore structure, fix high, low match 9939537ea44 debt - use main in main side services consistently (workspaces) d7ddcd1e08c debt - cleanup WebFileSystemAccess#supported 6b1675af7e7 Open Language Mode picker for new file (fixes #110330) affac2b5ae0 Fixes #104004: Do not attempt to run extension tests in web worker extension host 2ef14cf785a fix workspace tests on windows 1848d3111fc Add workaround for #114227 ed00aebc389 Link names 98b4661b002 :lipstick: fed0eb5fd9a web - remove old API interfaces c7cb19ed216 Merge pull request #114749 from microsoft/ben/folder-id e5dd4b6e4b1 Add mock support for public ports to test resolver 4c0a4179e6e workspace - more tests for identifiers 106f26b27bc bulkEditService: dispose of listener in finally 1285843e55e When a tree resource has a tooltip it takes precedent 3ee49fa3f86 explorer: when new file system provider registered set whole explorer input 05bf7b0afcf Merge branch 'master' into ben/folder-id ec337988dd6 parseUri/Path => resolveUri/Path f9d16c3b3c2 fix tests 3f26fd17ba5 workspaces - some final :lipstick: cf4c4a0ece7 drop gulp-cssnano, use gulp-postcss b87d56c5332 distro 2e5034a74b2 Retry downloading playwright when hitting ECONNRESET f1e62c1190f upgrade dev dependencies 9321b2f141b bulkEditService: veto shutdown if bulkEdit is in progress dca2d81c652 upgrade build azure-storage 70a3118892b Allow svg files to load from Schemas.vscodeRemoteResource 4f2341834e6 fix nls problem, fyi @JacksonKearl 70f4451001a remove unwanted #region comment from vscode.d.ts 2fd18ac793f workspaces - reduce stat calls e61d0ba267c mark secretState field as private 4b9ccf578c3 fix #114727. load preloads when switching kernels. 167b920831c Enable searchInOpenEditors by default when not in stable 7e55fa0c543 Search In Open Editors (#107756) 9f9d1a76d97 support kernel id and extension a8145f67dcc testing: polyfill test heirarchies (#114601) 572bc1810dc Make sure we dispose of the open with picker after an item is selected 542de8e0093 Move schemes to opener metadata 885585c7f87 Remove test math formula from readme 793f2e06af4 Fix weight of terminal search workspace keybinding 3d641d9d35b fix #111889. d972bfc3266 Update elliptic and nwmatcher (#114670) 7310b17e25f Merge pull request #114669 from microsoft/merogge/altClick dec03c4a714 Improve doc wording 219d323100f improve setting description and make setting true by default and add === 821afe5e929 fix #111885. avoid duplicated execution placeholder status bar item on split editors 59fac4862da Merge pull request #114665 from microsoft/sana-gettingstarted 3003bde2214 revert "Open" to "Focus Terminal" 4b9b2ab9a60 Fix #114707 dbd4ede23f8 add api lint rule for region comments 41d8bb26110 Merge branch 'master' into sana-gettingstarted e7d3eb87cb0 :lipstick: 565f3a59e6c @ for CI failures 98ee1c6efda update distro 3ec90672006 Simplify local port logic in test resolver + OS check f2b2854a6b2 (for now) have tab decoration off by default, https://github.com/microsoft/vscode/issues/49382 67f1ada71a6 chore - a few more strict assertions in tests e8f6c273819 Use random port if privileged in test resolver bdc3b07f428 Fixes microsoft/monaco-editor#2305: Account for padding when computing the content height and having scroll beyond last line enabled fcccc85ff97 Add more to test resolver tunnel factory and fix port filtering ad437ef958c Fixes microsoft/monaco-editor#2313: navigator.clipboard is not defined when loading not secure, via http d3fbbece829 :lipstick: 5a95cd26e4f Fix #114708 3ad7af3ab6b :lipstick: 9b7323a7efe cleanup types d8831220ff1 Update showCandidatePort for test resolver f6490bfa5fc :lipstick: getFolderId 758f66b5986 workspaces - actually use workspace 79230501646 Don't await remote env before setting up process manager 9ca50fbb47c Merge pull request #114702 from microsoft/tyriar/109600 4877478fb6e Hook up alt buffer active ctx key b5f36a24b63 testresolver: start a test server a49455b5286 :lipstick: isCurrentWorkspace af915f0bc4c Create terminalAltBufferActive ctx key 6755b6bb3e9 electron - need to check if window is destroyed before accessing webcontents b1cb3b1cbb1 Merge branch 'master' into ben/folder-id 37ea1d82847 Merge pull request #114660 from microsoft/isidorn/async-tree-diffIdentity 19e390d5b58 polish 04ca5c80d3f Merge pull request #114593 from jeanp413/fix-111572 0249c31a59b testResolve: more tunnelservice fixes c735c8b2913 Merge branch 'master' into alex/python-language-configuration 67bf6577b4d testResolver: fix for tunnel server b6f19ccf3fa CI notifications 7d5052a8fce Merge pull request #114687 from microsoft/alex/ci-windows-cache 15e58cea4d3 test resolver: add tunnel server 18c8a3f0482 workspaces - compute workspace ID and check for existance in window service e9967519db1 chore - strict asserting in snippet tests 515f179c98a decrease repl refresh timeout f63310750f6 Even more tunnel provider logging 44e020ac02b Trigger CI 05e4d593c23 workspaces - move id computation to main f5d760b48f3 Merge branch 'master' into isidorn/async-tree-diffIdentity 831d1942874 Create .build directory e8473247567 distro 4f98d9c0be7 no double reveal of notebook symbols 232052d7e63 Create our own node modules archive (#114516) 33789a59919 workspaces - drop duplicated payload interfaces dd84387f9e6 window - merge workspace and folderUri into one 0c02f245f07 bust node module caches 914d8dff29e add notebook for notebook paper cuts c71edb7d883 get marketplace extensions in `yarn web` f4a0c209bea formatting c8ce53e492e window - reduce to one property for opened workspace f19f4a1b908 Fix Keep activity bar icons stable on reload (Web & Remote window) #114144 9cfba546810 move build/dependencies.js to typescript acaed317263 workspaces - add identifier to single folder identifier 7e2d8b48e36 Merge pull request #114581 from microsoft/chrisdias/solongsofar 3207692dbbd Merge branch 'master' into chrisdias/solongsofar 44eb775d1db further remove single workspace identifier traces 46b964b1b7c workspaces - remove ISingleFolderWorkspaceIdentifier requirement from workspace service 47a6682df6f fix: allow svg from devtools scheme eaaf647c8c5 workspaces - remove ISingleFolderWorkspaceIdentifier requirement from history aa774aeeb79 :lipstick: regions 71feb05bfba :lipstick: workspace payload 6b241a6845d Closes #111210 - adds openRepository api 5bcd2220750 Fixes checking for rebase against wrong branch Refs: #1866 1a4b35c2023 :guard: 26aaaeb11ca re #114583. 6e56202803c pin notebook editor when execution triggered. ece4eeb0647 only handle override when id is provided. a2830f41653 execute notebook with args 1c755a4fca2 fix #114674. 9a55eff36fa testing: make filtering work correctly 847c52e69fa testing: add hover titles for items 0e9e4e46774 testing: show stats about the last test run aa14d823df5 testing: show badge for running/failed tests c2a2e9cabf8 testing: show test progress, implement result service 48c7596e909 testing: fix swapped run and debug actions c6e62500779 Merge branch 'master' into chrisdias/solongsofar 1123ea5791b set false by default and consider multiCursor de24392e690 fix #114583. 79ec33ab1eb Merge branch 'master' into chrisdias/solongsofar f087f82a3b8 allow reopen notebook with another view type if not dirty. 559a63373fc fix active notebook editor in repen with quick pick 3fef8c795c5 Update gettingStartedContent.ts d591739670c Fix #97564 (#114438) 5717c0396ad update distro 1509770d10d Fixes #58440: Finalize `OnEnterRule.previousLineText` API aab5336e534 polish 9b1d85bad8c repl and explorer adopt diffIdentityProvider be4d10efa1b async tree pass on diffIdentityProvider to regular tree 28b221faa8b Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#114648) 2e40c684ecf Bump fstream from 1.0.11 to 1.0.12 (#114649) bc3a873ee6f Bump macaddress from 0.2.8 to 0.2.9 (#114647) f9109f4464c Bump sshpk from 1.13.1 to 1.16.1 (#114645) d3965a2b4dd Finalize secrets API, closes #112249 699b02d3ae3 Bump hoek from 4.2.0 to 4.2.1 (#114643) 93ae815ba14 Feedback on secrets API #112249 64fa272029d Bump stringstream from 0.0.5 to 0.0.6 (#114618) 1266a4e4d05 Support git-cmd.exe as a git bash shell cbbf2d09904 Correctly resolve mapped drive on Windows 7139a93a8c7 Bump mixin-deep from 1.3.1 to 1.3.2 (#114619) a011dab93e6 Fix #114639 ec1eda0d96c Rename `OnEnterRule.oneLineAboveText` to `previousLineText` after API call feedback (#58440) 38c051bf865 Catch errors in tunnel providers and log 947626dfa4b fixes #114616 bab7a83909b shared process - check for destroyed webcontents before calling postMessage b0883ec87a9 Properly call dispose in tunnel factory We really need a lint rule or something for awaiting/not calling functions 02f7983156e More tunnel logging a7980b630c0 some initial :lipstick: 0b038406a95 :up: distro 6c4203f7482 Modernize CLI main (#114623) aaf5a7fee3b Merge pull request #110912 from Wscats/enoyao-Environemt2Environment e2bce32da4b #114627 complete fix 0fbab387483 :lipstick: strict assertions in extHost, mainThread tests 5cec4e2da6e don't expand outline tree when just updating, fixes https://github.com/microsoft/vscode/issues/114386 845a4d4268d add new rule to enforce Thenable over Promise, adopt in vscode.d.ts and vscode.proposed.d.ts dfc8f5ab91b comment-out console.log fyi @connor4312 e9263cc8269 some API proposal for open editors 543af670531 fixes #114607 2d5f7fd0726 Move `onEnterRules` to `language-configuration.json` 87dba0db6b2 Fix #114627 368c03fdc8a Fixes #114348: Allow `onEnterRules` to be defined in the language configuration file 390dac56a51 debug dynamic configs: Use the type of the provider, not of the config since config sometimes have subtypes f9f87fb6fa1 Add logging for tunnel creation 37c4d4b0a83 fix https://github.com/microsoft/vscode/issues/114621 b675fa18cb4 'Resolving your shell environement is taking very long' shown in every window (fix #114622) 06ab012baa5 state service - actually implement interface 9deba1b10ae code catchup 4d0d36c6ab1 update distro b31660dccc7 update distro f3c865334d4 use real tsec instead of vscode-tsec fork c0a0a35a87c more clarifying comments for shell env resolve 6effd9dce9c better fix #114564 a16beb16509 testing: fix run all tests command b50bd5d0944 Close #114342 1f8643ef760 Refresh Images In Markdown Preview On Change (#114083) 686cd7df530 testing: clean up actions, add run/debug all, rm duplication bb1c05e62e2 testing: unify testing view f37dd663235 Revert "window - do not send IPC messages to destroyed windows (fix #114563)" 16ea22eea19 Update Codicons: Add 'combine' icon 7f4d67c94cb Fix #110812 (#114553) 049735e8d96 A case for 'Shift+Insert' added. Fixes #114103 (#114520) a11dd7cd48d fixes #114199 3ed456050c7 Fixes #111572 6d6fec82092 Finalize product icon theme contributions. Fixes #113828 c42b385bcea Disable contributed openers by default in calls to openExternal fe81f9f5b26 Add link opening getting started task action. Closes #114582 3e4552ffcc7 Remove unneeded mapping from cintainers to disposableStore 3411ae55cc8 Allow splitting gettingStarted editors fixes #114321 fa2dbc16ca8 spacing 82a21e5a032 :evergreen_tree: 239213eaeb1 push it real good 3c4f06dc98a update distro 010e1d0e4a3 open in new tab 74f31a68598 Fix #111299 (#114441) 36cb0bde33a ci: disable exploration sync on PRs aef623dc1d3 remove "so far" from Problems message (which assumes you'll have problems later) eba7c23da0c trees: rename option to diffDepth b32d137681d Merge branch 'test-tree-testing' c100b5c26ac add clearUnacknowledgedChars flow control 6815e754602 Merge pull request #114237 from microsoft/smarter-indexed-setchildren bc84f07dc53 navigationActions: remove dependency to notebooks 81ec098e60e Merge remote-tracking branch 'origin/master' into smarter-indexed-setchildren 88835344408 trees: don't use diff identity provider for resort 7ae39d955d4 fix https://github.com/microsoft/vscode/issues/114576 ee4f4dbf97a make trusted types policy strict bcb5f3c77b7 update mkdirp fe1fdf0b4fe Use correct value to enable port finding 616fb1cfed2 Merge pull request #112317 from plainerman/fix-99072 c0c033ff4f7 Use port auto forwarding setting to disable port finding (#114574) b0b4bc4e338 add grammars scripts 15a285fd5ae Change "Requires Sudo" to "May Require Sudo" c6145fc3065 ext (un)link 4ff784e1fbf promise :lipstick: cf4111f6f89 show a modal dialog when no default formatter is configured, https://github.com/microsoft/vscode/issues/113903 dbf36e4cfb6 Change aria label when attaching f8df6a7e47d oops do not have .only 5a4d90a550a window - do not send IPC messages to destroyed windows (fix #114564) 635d7af6385 update ext types 7a34c6d6227 update tests 36929d3b59e exception widget: allow to tab over each link, enter to navigate to link 3c49afeaafa fix hygiene 867a52fc090 ext each: allowUnknownOption ff393a3349e add open tunnels to test resolver af2bcd4d461 bring back vscode-colorize-tests 0e7f3d0d8cb Revert "remove colorize-tests extension usage" 971190e4d0f fix region comment 81eccfbf68e cleanup native modules test 28ad78e7dc8 fix https://github.com/microsoft/vscode/issues/114537 af59db28c8d stream - some cleanup of observer 78d5286adb9 Bump sshpk from 1.13.1 to 1.16.1 in /build (#114534) 9af9580bf0a Bump stringstream from 0.0.5 to 0.0.6 in /build (#114533) b165e20587d InlineHint#hoverMessage becomes description (maybe better tooltip?) and support string OR markdown strings b47aa19443c FileService improvements (#114428) 2d9a0d12131 inline hints: tweak colors, react to theme change, add rounded corners to hints d29bb624a40 Merge pull request #113285 from Kingwl/signaure_arguments_label caa87e0b523 editor status :lipstick: 2472798cd57 Fix: selecting entry should focus back to editor (#114493) 32b28f6f8f9 And again bump distro ce106c3924a Bump distro again. ced398d18a8 Bump distro 30f17c9572a Merge branch 'master' into signaure_arguments_label dc588389507 remote install-extension with VSIX 18aa3199c23 Avoid `ERR_STREAM_WRITE_AFTER_END` 847300e49a9 support vsix for install-extension 92083ed3e18 yarn ext 085317e932e dev: ls d6ca7769f42 create extension workspaces bcf514160be uninstall-extension should remove both local and remote extension a40b4e72d08 add API command `vscode.executeInlineHintProvider` and some end-to-end tests ac85fb8a74b fixes #112045 7a938679f82 clamp font size at editor font size, don't go bigger d65ab8dcd9a use all of context decoration as decoration type key 4af282ea26d explorer: download report progress in the explorer due to rich download progress to not get double notifications 1d3b03bd551 padding should depend on font size too 4651f66cca1 simpler decoration type management (rely on internal ref counting) dab702a135e extManCliService: Sort listExtensions, fix output f101028176c Fixes #114299: Add commands for invoking semantic tokens provider 5087b08c6d1 :lipstick: 1981776d0f9 less state inside InlineHintsController-type, only have one type of decorations, and much :lipstick: d427deac780 explorer: adopt confirmBeforeUndo 74f272fbb7d update distro c27642c76d6 Merge pull request #114421 from microsoft/aeschli/remoteCLIExtensionsManagement 0d4bf785b6c remove hover (should come via decoration) and action/menu (should be self contained if at all) 97f237272c9 rename remote commands to _remoteCLI ae67879ed5d don't propose new API on ThemableDecorationAttachmentRenderOptions 756337d48af Merge branch 'master' into signaure_arguments_label 2bb41a14025 dev script 2388c80c74c Add `confirmBeforeUndo` option on the undo redo element 407557ca234 Save file dialog: sort file types alphabetically (#114487) bf90bd15185 cliProgressMain: add LocalizationsService to ServiceCollection 911a54273ce Merge branch 'joao/fix-web' 9995d128240 missing build output 09bc6fc64b1 Migrate to new deb repo (#114527) ed8655201ae fix web extensions 7fa8f1aa7fb Remove plug icon from ports view Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689 667e41626f1 explorer: if you can not undo, pass undo to editor 85f1501c861 update distro d3611cbb634 fix toString 2ef04b24f42 :lipstick: c208ec384c9 :lipstick: move all scoring logic into _doScore 9441f1c6457 Add support for npm scripts with a space (#113840) 253d99a16f8 update distro 84865c05ecc Merge branch 'master' into aeschli/remoteCLIExtensionsManagement 22e02e00804 use URI for VSIX paths 96001455045 Fix tunnel creation in web 1c131cf2657 Avoid extra fields ebac10e0a56 Avoid conflict error 3c2c937f991 Merge branch 'master' into signaure_arguments_label fcc00b29f5e Avoid ts changes (#2) 08f3bcec33d fix https://github.com/microsoft/vscode/issues/114518 c16956439b3 Bust node module cache 5560c9f4da0 Fix #114455 0a2b6d4a1c6 inline collapse all actions 141b275c41f Merge pull request #114260 from microsoft/sandy081/comments/fix92038 ff309d2a239 Merge branch 'master' into sandy081/comments/fix92038 39edf4351b9 Trigger GH CI 12ef541b365 :up: distro ff9fbcb077b telemetry - lift some helpers to electron-sandbox 93b5a0591f7 sandbox - lift remote agent service to electron-sandbox 9cea4954aa5 notifications :lipstick: 691951c3b1c editor title - no need to update menu onDidRegisterExtensions ec5d1c2ab93 debt - push more window related things to window helper class eaa959d34b8 fix #114273 253e9e32261 shared process - consolidate services 0c8cf08b44b shared process - drop management service 1caaf1b2dbd :lipstick: path labels 61312f3708d Remove instantiation service accessor 2e89c2d4ba5 Add 'key' to onDidChange of secrets API, #112249 c5f0bac2a81 Create issue directly if signed in, fixes #95165 0faf1550289 Disable on enter test 48b726e39e7 Fix regex 5f6acfb68e1 Move jsdoc completion tests to smoke tests 800e173c403 Split ts into unit and smoke tests b813d5dd300 Leave the local extension host running when connection is lost to the remote extension host 3a9daf3e34a Adopt new vscode-userdata path format bec5afa2923 fix: remove unnessary asar files from mac arm64 a31b0617e24 expose altClickMovesCursor as setting (#114429) b2575665d82 Emmet wrap update, fixes #113930 21c11ba864c Fixes #114433 - adds setting to avoid git config 79cfca5aa29 fix #114416 LabelService.getUriLabel bad relative path if in root workspace (#114419) 5a25a566959 workbench.action.debug.start => workbench.action.debug.selectandstart a3febc56143 Potential new formatter for userdata in serverless. (#114296) 663532c3173 Skipping unreliable test a68f1326e87 Update built markdown preview code 308a4f6a484 Make sure ts extension has loaded before running on-enter tests d87041eddef Downgrade simple browser to prompt instead of being the default on web 3310d3ac2d4 sort notebook content providers in the list. 03dd7bf1d91 testing: polish and unit tests for the test tree 337b3e8d055 turn on flow control by default 7c4248780c8 adopt useCustom for permanent connection failure 2137a7f8508 implement useCustom in dialogService 5b8f78a1570 Move sync-enabled trigger to gettingStartedService 67c988005f9 Do not wait for the first reconnection attempt in the reconnection loop b64a4ae1aa3 Scaffold `MessageOptions.useCustom` 6d50c71f41c add editor command, fyi @dbaeumer ff042e9fa40 fixes #114203 381b99f6415 Also run the output based auto port forwarding (#114424) f7e7a95479e Merge branch 'joao/remove-grammar-extensions' bf764f1ce6a wip: sync-extensions dev script c198925570c extensionsManagement for remote CLI 4974a335112 smoke tests are tests too f745a912ae1 fixes #114420 62bb9b3d3fd shared process - adopt toggle method from management service 65582ba33d4 Fix #114326 0442b734227 remove devops ci badge d472f9d503c remove devops continuous build f8dbf7dd079 Merge pull request #114359 from microsoft/ben/shared-process-message-port 4af3c1c0576 get grammar extensions from marketplace 217aab28fac breakpoint polish condition context keys 6ca430e6a6f Merge branch 'master' into ben/shared-process-message-port 55325988a07 shared process - basic message port tests d952c818176 Fix #114379 6f9f6f806c1 Azure DevOps pipeline artifacts (#114405) d577c4b18da remove colorize-tests extension usage bc7d3c9ea6d remove grammar extensions be2732570ac Include tunnel service canElevate check 6889ed3ab17 Notification for elevating when using privileged port from openTunnel 25a9fcdb918 Merge pull request #114388 from jeanp413/watch-copy-value-selection 98acb74149d shared process - fix --status invocation addb6b9b53a :lipstick: 55e10fd785a shared process - introduce a separate service for management 22c1c0b486d update distro again ba7f5c60a5e update distro 5d620dc8466 Update Linux publish script 45e8d6ebc65 Update distro commit c082930a439 shared process - introduce platform/sharedProcess ec2a8e5b9ee shared process - rely on "close" event for disconnects 9e1863ec2dc shared process - :lipstick: 98d2d74ba07 Revert "Publish scripts update (#114375)" 99f0ab9f732 Publish scripts update (#114375) 2bf5b56f115 shared process - move the shared process back to IPC folder 8dff4cfa55d Expanding Getting Started text based on first round of feedback. bcb33ef6290 Merge branch 'master' into ben/shared-process-message-port 9c7128d8fab Fixes #114384 - recheck resources after save/add 746c455458c Respect multi selection when Copy value in Watch Expression View. Fix #114353 1894765dd17 Merge branch 'master' into smarter-indexed-setchildren 1a6eef3170b Update image ref 54cb0ed544e Clean up settings sync entry 4207c4ee13e Move defaultExternalUriOpenerId into configuration to avoid cycle 5c39159acb4 Fix cycle 4566eebe4fa Fix typo in markdown sanitizer (#111258) a34e751b017 Fix scrolling of markdown preview. Close #65504 (#111094) 64496f82196 Allow using 'default' to force fall back to VS Code's default opener 6cceb4eab08 Remove enabled setting and try to open simple browser to side of current editor 1e3a23b4e0a Fix simple browser button color for light themes cc5e8b22faf Continue work on url opener api a590d4fac36 Only show "Open in VSCode..." when isWeb. 67c889e3941 Merge and restructure menu (#114383) 56a6279a1c8 Don't use getActions in search view #92038 856277c8590 Github Login => Setting Sync ad3974ad88a :lipstick: e32e353bfde fix #114171. 255853d1714 Remove emptyWorkspaceSupport when conditions 11d18c2c094 `remoteName == codespaces` for codespaces section 9f3832dc688 Bust the node module cache 5029b4f362d Fixes #112552: Set server marks to `ITimerService` 9cb4f1e2ae4 update distro 43d111c0a48 Getting started content (#114305) a4b13661009 Add performance marks to `IRemoteAgentEnvironmentDTO` cbb94cfb607 Revert "fixes #114203" 8dfc81fedc1 Small tweaks ff7aabe3fca fix #114215 c8a6ddba9d0 Enable forceConsistentCasingInFileNames flag (#114334) 6525b42f479 remove unused file e12a9d74a62 #114144 fix remote explorer icon flickering d03490f3532 fixes #114203 f34a3ace3f9 update distro 55960b7d61e add flowControl to terminalConfig 7ae54ca2d6f breakpoint widget: use same mode for coloring as the underlying editor 835a1ce6efd allow execution against a hidden notebook editor. 5d6cba5cbc2 Reworking external opener implementation to allow configured openers to be called directly without a canOpen check 5b1e59c636c explorer: hide open editors for new users e1d8b926583 update distro 30f61c2449b part of #114214 serverSpawn=true c4d5b055d37 Merge pull request #114269 from microsoft/alex/fuzzy-score-improvements d4f993de63e Saving an untitled file closes it (fix #114272) e44fb4ab927 update distro 526f826ac14 fix #114192 634ebecb8b7 Refactor code to use `await` 3e6535d882c shared process - implement message port connections and wire in d6f27b92719 Polishing/fixing/addressing feedback for portsAttributes Includes: - fix in json schema - use object instead of array - change label of already forwarded ports when setting changed - fix for merging ranges c972009ef68 Merge pull request #114214 from microsoft/tyriar/flow_control cc8c9a2230d No need to store scores a79276dc649 Move to log service f8ec60aa06f Add flow control setting, remove fake latency 98038a8835d Merge pull request #114208 from gjsjohnmurray/fix-37570 065f0e46405 Auto forwarding fix 7a9bb5a44f9 breakpoints: inline action to edit condition. Render conditions for function breakpoints. Allow to edit conditions for function breakpoints e9f6c35c17c Fixes #114146: Increase max BracketSelectionRangeProvider duration to 5s in unit tests 4e4d2484a74 Extract `TestTextResourcePropertiesService` to its own file 00f8540d793 Fixes #114332 f1cb1b27f3e format 40e3106e5fa fix list drag affordance 7899bfe3eee Merge pull request #113315 from qchateau/fix-semantic-highlight db30147068f Add test for case to assert that fetch should be scheduled again when a text buffer change occurs while the provider runs and the provider returns null 44278132f4f fix peek view alignment cd906568752 shared process - document electron IPC 96b44121f98 shared process - add error handler and graceful-fs 2964fcbb846 shared process - extract more cleanup helpers to contrib f1c510b4a88 Merge branch 'master' into ben/shared-process-message-ports c265dff48a2 chore: bump [email protected] a8dd7f60a62 update collapsible when children change 710846866f7 Activate extension on simpleBrowser.api.open b7f9eddf043 Allow passing viewColumn to simpleBrowser.api.open 9b83eb6eb50 smarter depth selection a1d5ea876c3 Polish, also fix #113930 2b5ae783bf6 testing: add full json reporter to show more complete output d39eefd1b0d update distro 59891debcf0 Wait for outstanding zlib flushes when draining a WebSocketNodeSocket (#114314) ea13176ee96 Enable image preview for avif images 7da421d99bd fixup! make it work for compressed trees, recurse 6c4a00ce747 Make default text editor replace existing editors for resource (#112848) a59f30011c1 Add a 30min cap to CI jobs e7aa009ac3c Remove enabledHosts setting 61ec57016c4 Fix spelling 47aa3ad09ab Continue work on opener service d6936dd524c Add mechanism for snippets to overwrite Auto-closing pairs in some cases (#114235) 2ca7b5426a7 :lipstick: fb6a9b4824b fix #114289. notebook.selectKernel takes kernel id. 2156b8cc758 check and ignore not found error 31a15b5b9a3 Add command to kill server and trigger handled error 23be24d8289 Allow theming getting started page progress bars closes #114303 2774f79df3f Do not show "Cannot reconnect. Please reload the window" if the cause is a handled RemoteAuthorityResolverError 56e05127690 move to browser namespace e5e791003f4 Merge remote-tracking branch 'origin/master' into smarter-indexed-setchildren 2d892ae9c7f Fix arch check for PowerShell enumeration (#114292) 3ca55d031b1 Update Codicons: increase gap around plus icon (fixes #114016) b903748b833 Fix candidate filter and auto forwarding wiring (#114290) d66db5cc754 fix https://github.com/microsoft/vscode/issues/114220 c88a51e10a8 Merge branch 'master' into fix/debug-auto-decode-link 4450e1d827d Azure DevOps - publish Windows artifacts (#114285) 42d7d3a47d7 breakpoints view: render edit action inline for exception breakpoints 40d6f79875b MenuItemAction: make sure to respec item.icon a198be16f93 shared process - some :lipstick: 67f8c0ca5a2 Merge branch 'master' into ben/shared-process-message-ports daa7afebd06 remove undefined from outline data source cf03ef33f45 allow to clear input of data trees, fyi @joaomoreno 0ecb7735496 shared process - more cleanup dea0095e83e Add icon for public vs private ports 212a9434541 Merge remote-tracking branch 'origin/master' into alex/fuzzy-score-improvements 36a9cb8645e Improve `fuzzyScore` 475d3464e87 Have single outline config and let outline creator know for what they create outlines 9266fc49839 mock a label service to avoid breaking layers in tests 9af036b8274 Fix comments b4e4bd16421 Allow tunnel providers to support making a tunnel public 9853c8fe6d7 Fix cr issues a4f9e607619 fix https://github.com/microsoft/vscode/issues/114266 2376bed71e1 :lipstick: some region-comment polish 64f32932c68 debug console: fix error in console, do not bind to same htmlelement a scoped context key service 75ea87a2636 shared process - introduce platform/sharedprocess dcce02644ea fix https://github.com/microsoft/vscode/issues/109658 5ce7b02b6e8 refresh the remote indicator when actions change 5db4708e99d shared process - avoid payload IPC roundtrip and enable console based logger 6fef673683f update distro de4463874c4 callStack: do not use getActions() 152d0ec8f05 finalize CancellationError API, fixes https://github.com/microsoft/vscode/issues/93686 adb037b74d8 fixes #114137 e59dc77d0d2 shared process - more cleanup 3f37b664fcb adhere to DAP spec; fixes #114229 e776f87e140 fix --builtin 7285f791ee5 Use menu 1fae5211635 shared process - more cleanup 9bfa4c1d558 Merge branch 'joao/extract-extensions/themes' 9c6e10497b5 use in-mem fsp 7eb52e75e08 shared process - more renames eba7707d382 shared process - clean up some types and imports 675e5da76b1 shared process - expose methods for message channel API d0749f8c9a3 use in-mem fsp 936e77761b5 include error into startup error dialog (#112846) 68ba207260a List still dirty files when backup fails (#114064) d4be66da200 Fixes #112487 - avoid using stale cache for render d78fad382aa skip failing test on win32 (#114248) fd0a3a12e7b Update wrapper class name for paramter hints 8f384b51a93 Fixes #114204 - always renders the input box 27b824b32c8 Adds ability to pass remote/refspec to pushTo cmds d076ee1b943 Adds force push mode to push api 02380e70149 Removes repo hint from args 7f489f589d8 Hide warnings for settings groups that have dynamically registered settings Fix #113747 d7d5f20047c Fix #114218 145bcd3a732 Insert new code cell should always use available languages. d536903a2b0 :lipstick: d88b60ceca6 languages in notebook document metadata. 8a2b9e9047d trees: add diffIdentityProvider for efficient setChildren updates b6435bc4240 Remove unused import 47a135e715e Rework opener api proposal 6184addcd1d fall back to homepath if home unset. closes #112775 b3d57e69b02 Update PHP grammar, fix #113185 92833fca559 fix #114233. 04efea43fa3 testing: peek diff test outputs 989f2eb812e setImmediate => setTimeout 02276814922 Add new external uri opener service 22c88cfaaeb Batch ack events coming from client 3232112f9ba Only resume if it's paused 60e46eb8756 Delay animating until content is prepared to prevent weird flying elements. 0738f76daca pull themes from the marketplace 0a19f7702a9 Rename ackId to charCount bf52d50a0a3 Remove ackId from data events going to client 7aee462b8a3 Use char count instead of ack ids 7e5c01208dd Start of low-high watermark flow control 69a6e6ac937 #113757 show panel move and hide actions only for panel views 3a4dcf4890d Fix unit test for Win32 release (#114212) a04802f5865 #113757 show panel move and hide actions on view context menu f29502563bb #113757 allign reset location action f1ee68fc468 add tests for RELATIVE_FILEPATH snippet variable c6c7ddd4437 Merge branch 'master' into tyriar/flow_control 6430ee1efce Basic flow control for ext host processes 9d39f4e6cb7 don't auto insert semicolons 169269a3f07 fix tests 3767f97bc32 Adds onDidPublish to Git api 8832366467e Closes #110881 - adds possibly rebased warning eba4da27278 #113757 show sidebar actions only on sidebar views 2e279d37e7e Property preview text wraps lines in debug console 554ae13fa9a Fix address for port open attribute Part of https://github.com/microsoft/vscode-remote-release/issues/4046 b7b36bb1908 remove some tests 9ecba1b468e Merge pull request #114039 from microsoft/isidorn/bulkFileEditsUseTextFileService 1e9b86da1f9 Finalize adding a cancellation token to resolveTreeItem Fixes #111614 161ce44ddae Azure DevOps - Move release into a separate stage (#114205) d3e4bdb6177 Merge branch 'master' into joao/wsl c644f3788d0 revert wsl and distro 3a1c42c150e textFileService make getEncodedReadable public 67f9988bdc4 Support to define additional attributes for ports Part of microsoft/vscode-remote-release#4046 53be807cb4d throw nice error (and prevent stackoverflow) when instantiating services recrusively 3653f34dbab Do not instantiate hover widgets in the `onModelDecorationsChanged` event 0a28ec7fb14 fix #37570 add RELATIVE_FILEPATH snippet variable 868271067e6 filter perf marks that don't start with 'code/' 675638196d2 debt - remove duplicate drive letter implementations 4816a253eaa Revert "use PerformanceObserver in node's perf-util" 05c4659e096 use PerformanceObserver in node's perf-util e500f76d9cc remove test dependency on theme extensions 0324150670f Merge branch 'master' into isidorn/bulkFileEditsUseTextFileService d88c1b4a64c Merge branch 'master' into isidorn/bulkFileEditsUseTextFileService 22bd999e86b debt - use provider extUri in file service 4b3ab7048fc :lipstick: b90166177bf reuse stats collector for EchoRunner, fix missing titlePath-property, fixes https://github.com/microsoft/vscode/issues/114190 7a8c7f57312 activity bar - use IAction in more places b5b160e015e activity bar - show a "Hide" entry for accounts and home indicator (fix #113757) 7ab5c2a90ae activity bar - consistently show right click menu everywhere (#113757) f675564c5dc fix #114028 e17aea136d3 Fix #114189 - disable caching b9aaba047c6 activity bar - remove "Hide" from left click menus (#113757) 2b0132d09f1 activity bar - update order of entries to reflect visual order (#113757) b33b28dd078 Activate onStartupFinished (#110031) d61eb64745c activity bar - change visibility of entries to checkboxes (#113757) 6dc779565e1 :up: distro 913fff96a3c testing: fix error when test view is hidden after showing f5665378fd2 testing: start of diff peek view 09d99f7d71b resolve kernel providers and kernels. 732d4ff89e8 Make PowerShell 7 default if available and show in choose shell menu (#112768) 74038b7e0d8 do not use file scheme c88ab9e0b63 use in-mem fsp - remote folder config tests 506ae4a53e7 use in-mem fsp - multi root workspace config tests da3a21ee4e6 Merge pull request #112602 from microsoft/rebornix/output-view-model 041a5c3b6b9 fix tests - do not use file scheme f92251d8e61 use in-mem fsp - workspace folder config tests 1e44ae5da86 Merge branch 'master' into rebornix/output-view-model 03450bf0941 Update Codicons: Update '+' modifier location (fixes #114016) 84f2cf6449a use in-mem fsp - workspace init tests 722a6664f84 use in-mem fsp - workspace editing tests a2efefd3713 use in-mem fsp - workspace tests e3b18fa3efb testing: add filter box 676bb6b100e Merge pull request #114127 from shskwmt/fix/113603 990906a1655 Adopt strict assertions 00a781f926e debug: use mnemonicTitle and avoid dupliacte registration c38c1f497f2 use in-mem fsp - workspace folder tests 42221c900ba Set override to false when reopening editors after dragging them to a different editor group. This fixes #109000. (#114093) 31e33c478e5 Fixes #114042: Use Buffer only when it is available cef7004a46a activate search result extension onLanguage:search-result #110031 39619a136b6 minor polish e8fb4fd30da bulkFileEdits: use textFileService only for creating empty files c85297669ee Move id, label, and options to authentication provider registration e9ae0082963 use in-mem fsp in tests 3f3e35bf17e Add boundary for right arrow typeahead and fix bug with resetting Terminal (#113863) 61c6334a3f8 Fixes #112373: The hover should always consume mouse wheel events 3d500ebd8b4 Adopt proposed `CancellationError` (#93686) 5c1543b556c File name in editor tab reverts casing on save (fix #114096) 76c22d48c82 Merge branch 'master' into fix-semantic-highlight e149bdb42ac Merge pull request #113837 from HaoboGu/HaoboGu/issue113404 1551d1f1ff0 Fixes microsoft/vscode-remote-release#1485: Make sure to only render Reload Window prompt once c9bae24fb70 More UX feedback 7cf2ad082f9 Render remote name when reconnecting cba1d1b1848 Prefix all `performance.mark` calls with `code/` 64947067ab7 :lipstick: unit tests 533d094020f Allow logging FS access with stacks 8ec95fa3b7a tests - improve ext path tests 55bd92dd538 tests - extpath tasks are flaky ea7b8ddda3e Can't open, rename or delete files that contains ":" on linux (fix microsoft/vscode-remote-release#4227) e3f5b3dfe47 Merge branch 'master' into HaoboGu/issue113404 bd5c20448c5 Merge pull request #114129 from microsoft/alex/configuration-editing-tests-improvements c173fb7d72a #114144 revert showing cached theme icons 088304c9968 #114144 - Do not cache only uri icon efb833ab7c7 Merge branch 'master' into HaoboGu/issue113404 5755d943ca6 Tests must be compiled even when `yarn` is executed acb0a35629d cache icon paths in web 73b4dabb2d4 Make lint happy d1cfec44472 :lipstick: 8b288893a92 Merge pull request #114101 from shskwmt/fix/113807_parse_args d541d7c64c6 make SubmenuAction strict: don't allow changing its properties, make it not disposable ea756907598 - Make cached configurations not disposables - use workspace configuration disposables 31a53bb2427 :lipstick: 43310230886 Merge branch 'master' into signaure_arguments_label 175e2c0b1d1 `yarn` is already installed (fixes #114140) b57739f4a24 tests - more use of getRandomTestPath 64a14963f7b Expose actions to duplicate editor groups (fix #114132) 60bc00ff63d webpack config typing fix f6bbc8b68d4 update tsec tool cfb2ad879a3 Update src/vs/workbench/services/configuration/browser/configuration.ts e25cbb45e7a Dispose all Disposables from tests (fixes #114125) 2fd00ba9fef Add a way to troubleshoot fs calls 57c405c24c3 Change reason for moveWordCommand to CursorChangeReason.Explicit 7c3aacb40aa Add a mechanism to track disposables from unit tests 11ac71b2722 editors - cache previously used layout and return it 03cb2d2a236 Dispose `PieceTreeTextBuffer` instances e114a24d9f9 Improve usage of Disposable e71f31abe9c editors - copied group is missing to register editor listeners 313f4bfecdc fix #113620 db701d281f7 Fixed not to skip determination of option type starting with "_" 3ceb3a100ed tabs - improve logic of previously used dimensions and relayout 6bd7b70515d Revert "Enable webview tests (#114059)" 0a3a9ce7bb9 State of tabs is not fully updated when toggling workbench.editor.wrapTabs (fix #113808) b0e96922417 tests - selectively enable some previously skipped tests ea1b3f27db4 Fixes window border causes webviews to be positioned slightly off (#114061) 01c6003c295 Enable webview tests (#114059) a12a996d780 Retry idb tests. Ref #114025. 7a7d11fcc6d Merge branch 'testing-group-by-result' 5f2036033c0 testing: improve projection logic, add state grouping e3509b62fe6 Add search.mode option to control default search experience (#114015) d110d503425 Remove webviewHasOwnEditFunctions context 50dd2dd3f9e Add context for when the webview supports find d8a3dd44be1 Removed unused param 0fafaab62e2 mnemonicTitle in native menubarControl d95e22d0a8d make menubarControl prefer mnemonicTitle, make MenuItemAction only implement IAction 8d8ee957418 options for getActions() are optional c88c207e6c0 fixes #114028 6828ae1ab50 Removes trim & fixes regex c45eac1a819 tests - use explicit skip over handling within test 8d46328a407 more :lipstick: 832afd1276d :lipstick: 15cd2a1abd2 #115025 hash the uri and create css rule aa5064d4fd4 Lift some tests to browser (#114041) d6a63fc79ea FS improvements for unit tests (#114026) a2251a3b6b9 do not use mnemonicTitle for all action titles, #102361 3898af5db3d typos 10592747998 refs #102361 mnemonic as command model property 8ae693bee2c bulk file edits: make sure to use textFileService when creating files bebd0664073 Fix gulp task provider so that it doesn't always try to run 29e0cfd8beb Always elevate (if needed) for openTunnel API e7c84aab5b1 Fix privileged port elevation flow from UI 61187660af3 Fix #114031 114e38f175e suggest - add min height when persisting widget height 2042a0e4c23 Add new terminal link text for tunnels (#114033) 174259eec8f Log when lsof fails and return initial fe175afdb80 list widget should not remove rows from DOM when reusing 91a0d07f3e7 Improve `canTunnel` Part of microsoft/vscode-internalbacklog#1709 288e8c233a8 Fix #110525 5ed73f6e850 don't theme icon for MD elements 6d2e0aa21d3 rename tsc config file for better intellisense ec4c9f4c8f7 Merge pull request #112833 from homebysix/list-extensions 7b16f15d005 Merge branch 'master' into list-extensions a5a0c1527d1 add tsec config and exemption file (defunct?) ca6a7a69989 :lipstick: 5adcd2521e9 Fix #113257 ed6c343edb7 gracefull fallback for TrustedFunction 44c9b4bb7f3 use TrustedFunction workaround when loading extension sources inside web worker eb940d4ed6d Fix #113988 adc68dc3561 Add `canTunnel` to tunnel service Part of microsoft/vscode-internalbacklog#1709 128987f575e remove duplicate step 4c42e6c111b Fix #114013 35766c616cb #113757 show sidebar actions also on view title context menu e4dc7b4d796 Clarify OpenDialogOptions note (#113831) (#113998) eb409622888 tests (unit, electron) - set forbidOnly when running on build machine 691da329d66 Revert "refs: mnemonic as command model property #102361" 96e2981c91c skip failing test (#113882) 82dc292811a Merge branch 'master' into HaoboGu/issue113404 0949d5b794f Remove unused var acda4aed821 Make the external opener a two phase process aa73c2d435d Fix random focus lost issues on CTRL+1/2 for a webview (#111676) 045b0fc4c09 Fixes #110509 - handles markdown escaping & spaces 31d5e48d92a Fixes #114002: Finish writing any outstanding messages before disposing d36b3616e70 Change Emmet to onStartupFinished #110031 b041f460ce6 Show a disconnection dialog only after 40-50 seconds 455b029ad1a Render "Reconnecting..." in status bar and use "Disconnected" only for permanent disconnection 5d9e867aa4f refs: mnemonic as command model property #102361 3dc0203e021 testing: auto reveal selected tests e2c305f3a3b Allow registering additional external uri openers bdf57b45ced Remove button background in simple browser aa85ab9d03e Make sure we also log event when creating a iframe based webview d964664da29 Disable dynamic cwd resolution on Big Sur d68056d9072 Improvements to batched testing. Ref #113911, #109271 8c3f5dd3fad Support to start multiple debug sessions from a single launch config 80f369b7bee reduce number of entires in test batch. ref #113911 2b20162d227 Avoid hostname resolution in lsof 70e37bec1be Fix #113920: Codicon => ThemeIcon 16452c54f38 Merge pull request #113938 from microsoft/alex/terminal-exthost-improvements 98cc02c097d change default zenMode.restore to true bbb0aadc87d enable trusted types by keep a yelling default policy for a day to two, https://github.com/microsoft/vscode/issues/103699 23ac286dccc #113975 use insance to remove svgs tags e803459d4ad fixes #113921 8ad08b04f5e Do not compile `/test/` and `/build/` scripts during postinstall, the scripts get compiled explicitly during CI fa701a373b7 update references viewlet aa48a4eff7b `monaco-compile-check` is covered by the GitHub CI b1877cd33e2 Merge pull request #112033 from solomatov/error-handling-in-terminal-start a7cf03de2db Add elevation message to ports UI (#113990) efd298ccbdb Fix #113760 a78fffbdb01 remove unused eslint mocha 72572c59cfb bust the node modules cache 578c3d5374e fix #113781 d4c32800737 tabs - polish how to detect that scrollbar needs update 683a30f74c4 Revert "better fix for https://github.com/microsoft/vscode/issues/113852" 7222c005ca9 update loader, event better fix for https://github.com/microsoft/vscode/issues/113852 c1930b6baf6 make default policy strict, https://github.com/microsoft/vscode/issues/113975 cdb373186cd refince CSP for trusted types but don't yet enable it, https://github.com/microsoft/vscode/issues/103699 a9dc6d28fde use default tt policy to workaround electron webview innerHTML-usage, https://github.com/microsoft/vscode/issues/113975 d5fc23ce6ce Wrapping tabs: editor toolbar bleeds into tab when space is limited (fix #113926) 14bb2fdc128 Tunnels from a tunnel factory can have async dispose a84603f49ff fix condition f2dd0954925 add (disabled but almost ready) CSP for trusted types, https://github.com/microsoft/vscode/issues/103699 4aff4b99239 trusted types - loader should use trusted script url when using script tags, https://github.com/microsoft/vscode/issues/103699 de9e9c414ef fix path in tsec-compile-check df10825f69e fix yaml 5e673678ebd Merge branch 'joao/build/single-compile-job' 575f87306f9 Merge branch 'joao/build/esbuild' fb4a88e4037 rename ab3297dd136 only run terrapin on cache miss 11b79ba7ebb parameters d495358b01d add parameter display names d944b91cd1b remove no-exclusive-tests 39810d812ef Sandbox: adopt forcefullyCrashRenderer when reloading unhealthy renderer (fix #112485) 2b7435c389c window - focus() window that opens from protocolHandler af5adb530a3 Revert "add arch to cached data path, https://github.com/microsoft/vscode/issues/113852" d687818f8e1 better fix for https://github.com/microsoft/vscode/issues/113852 2d114755e83 update distro 4149b09417d parallelize eslint and hygiene in product-compile a4f9970924b Merge pull request #113826 from nrayburn-tech/issue-109438 74bc1d2672e re-enable test for https://github.com/microsoft/vscode/issues/111867 c6ceb1ab2ea isolate eslint from hygiene 519f8691bad fix typo 935cbe6aff3 update test cases 3759568789d support more unicode chars in isSeparatorAtPos 685999bcf35 Merge branch 'master' into HaoboGu/issue113404 e269e5e2c6c revert back using switch for isSeparatorAtPos, add several cases f3b2680ee3a Merge branch 'master' into alex/terminal-exthost-improvements 01089c0a505 testing: fix unit tests e2c91378410 testing: fix unit tests 59091157571 testing: code lens and diagnostic information for tests 3d8888779d9 Fixes #112446: Avoid timeouts in mirroring terminals to the extension host by assigning a temporary UUID to terminals created on the extension host side f1151f84ff7 Adds userAgent to clone, pull, fetch - #111909 Changes to use env 6802a656e26 Use cast instead of generic 271d9b8c007 better hygiene task definition 809d2f63d0e Added show options to simple browser open command 2fed7ba374d Adding settings to control which schemes simple browser is enabled for ba67d1bea44 Add more explicit type for TS 4.2 af6d164f73e single compile job cb67fffb94b improve hygiene glob patterns 27e26536f12 :lipstick: e4fe157544f equal => strictEqual f489602633a Merge pull request #113919 from microsoft/isidorn/workingCopyFileService 4aca944132c make sure to not fire any events for empty opertaions array 4f109404604 minor polish de8b6772761 Skip batching test due to failing on build machines. Ref #113911. ac10e57f6cf fix: The git commit message field is cropped with negative zoom (#112316) a7267aa0935 Update distro e8edff5eb7e [email protected] 3259985c7af rename random_uuid to just uuid 1ace7e34995 remove console.error on commands for noisy tests 6763d82fdd1 also filter before debouncing when menus change 6c12d89415b :lipstick: 9293f64e937 :perf: first filter and only then debounce event handling 43aebefbf62 use Date.now() in stop watch c8d91038302 :lipstick: 39dbcfcfbce Set remote.restoreForwardedPorts default to true c6cc7d61401 workginCopyFileService: only one event for multiple operations 4d4b9225d2c Fixes #113917: Add square brackets around ipv6 addresses 83b4d6c8ce0 :lipstick: 7a27b248841 fixes #113815 8389f072696 Azure Pipeline - Adopt pipeline parameters in favour of pipeline variables (#113902) bb4cbce9699 Revert "publish linux builds" c49ef6df61d [html] update auto-rename-tag to linkedEditing migration 4fe3f75c6d3 Use `nodeSocketFactory` for tunnels for now (#113914) 1228854b4ae A…

jrieken · 2021-06-25T13:47:12Z

We didn't get to celebrate this properly but VS Code ships with trusted types enabled since quite while. Closing this epic, popping a drink, and thanks to everyone that has helped us here.

koto · 2021-06-25T13:59:43Z

Thank you Johannes, that was indeed a very joyful ride, and wouldn't be possible without y'all involvement! We're happy to help with anything TT in the future - but in the meantime, may your XSSes be 0 :)

(btw I think the default policy can now remove the Electron workaround? I'm happy to send a patch if so).

jrieken · 2021-06-25T14:10:32Z

(btw I think the default policy can now remove the Electron workaround? I'm happy to send a patch if so).

6c3defb :-)

annkamsk mentioned this issue Jul 31, 2020

Trusted Types compatibility: replace innerHTML with innerText when assigning non-html string #103700

Closed

vscode-triage-bot assigned mjbvz Jul 31, 2020

mjbvz assigned jrieken and unassigned mjbvz Jul 31, 2020

jrieken added engineering VS Code - Build / issue tracking / etc. plan-item VS Code - planned item for upcoming labels Aug 10, 2020

jrieken mentioned this issue Aug 12, 2020

Report trusted type violation during build and in editor #104489

Closed

This was referenced Aug 16, 2020

Iteration Plan for August 2020 #104735

Closed

Remote: Iteration Plan for August 2020 microsoft/vscode-remote-release#3523

Closed

This was referenced Aug 28, 2020

Trusted Types compatibility: renderCodicons – return HTMLElement instead of string #105588

Closed

Trusted Types compatibility: script for identifying violations #105747

Closed

jrieken mentioned this issue Sep 1, 2020

Trusted Types - Adopt renderCodiconAsElement #105799

Closed

3 tasks

This was referenced Sep 8, 2020

Fix Trusted Types violation (round #1) #106285

Closed

Fix Trusted Types violations (round #2) #106395

Closed

kieferrm mentioned this issue Sep 14, 2020

Iteration Plan for September 2020 #106677

Closed

41 tasks

kieferrm mentioned this issue Nov 16, 2020

Iteration Plan for November 2020 #110690

Closed

65 tasks

jrieken mentioned this issue Dec 2, 2020

Make xterm.js trusted types compliant xtermjs/xterm.js#3189

Closed

engelsdamien mentioned this issue Dec 8, 2020

Updates tsec and rewrites sinks assignement #112069

Merged

kieferrm mentioned this issue Dec 14, 2020

Iteration Plan for January 2021 #112419

Closed

73 tasks

jrieken added a commit that referenced this issue Jan 7, 2021

trusted types - loader should use trusted script url when using scrip…

4aff4b9

…t tags, #103699

jrieken added a commit that referenced this issue Jan 7, 2021

add (disabled but almost ready) CSP for trusted types, #103699

f2dd095

This was referenced Jan 7, 2021

Fix Trusted Types violations (round #4) #113975

Closed

[Feature Request]: Enable w3c trusted types usage with electron apps electron/electron#27211

Closed

jrieken added a commit that referenced this issue Jan 7, 2021

refince CSP for trusted types but don't yet enable it, #103699

cdb3731

jrieken added a commit that referenced this issue Jan 7, 2021

enable trusted types by keep a yelling default policy for a day to two,

bbb0aad

#103699

jrieken mentioned this issue Jan 13, 2021

Invalid warning on Worker assignment google/tsec#22

Closed

engelsdamien mentioned this issue Feb 11, 2021

Clean up tsec-compile-check output #116459

Closed

akosyakov mentioned this issue Feb 25, 2021

prepare for trusted types gitpod-io/gitpod#3269

Closed

setalosas mentioned this issue Mar 30, 2021

Untrusted html usage iocave/monkey-patch#22

Open

jrieken closed this as completed Jun 25, 2021

github-actions bot locked and limited conversation to collaborators Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trusted Types compatibility: Make VSCode TrustedTypes compliant #103699

Trusted Types compatibility: Make VSCode TrustedTypes compliant #103699

annkamsk commented Jul 31, 2020 •

edited

Loading

engelsdamien commented Aug 5, 2020

jrieken commented Aug 17, 2020

engelsdamien commented Aug 28, 2020

jrieken commented Aug 28, 2020

annkamsk commented Sep 15, 2020

engelsdamien commented Sep 23, 2020

jrieken commented Sep 24, 2020

engelsdamien commented Sep 24, 2020

jrieken commented Sep 24, 2020 •

edited

Loading

Siegrift commented Oct 9, 2020 •

edited

Loading

jrieken commented Jan 7, 2021

koto commented Jan 7, 2021

koto commented Jan 8, 2021

koto commented Jan 12, 2021

jrieken commented Jan 12, 2021

jrieken commented Jan 12, 2021

engelsdamien commented Jan 28, 2021

jrieken commented Feb 2, 2021

engelsdamien commented Feb 2, 2021

jrieken commented Feb 2, 2021

jrieken commented Jun 25, 2021

koto commented Jun 25, 2021 •

edited

Loading

jrieken commented Jun 25, 2021

Trusted Types compatibility: Make VSCode TrustedTypes compliant #103699

Trusted Types compatibility: Make VSCode TrustedTypes compliant #103699

Comments

annkamsk commented Jul 31, 2020 • edited Loading

What are Trusted Types

Why make VSCode compliant with Trusted Types?

Approximate cost of the effort

engelsdamien commented Aug 5, 2020

jrieken commented Aug 17, 2020

engelsdamien commented Aug 28, 2020

jrieken commented Aug 28, 2020

annkamsk commented Sep 15, 2020

innerHTML

setAttribute

Workers

Imports

DOMParser.parseFromString

engelsdamien commented Sep 23, 2020

jrieken commented Sep 24, 2020

engelsdamien commented Sep 24, 2020

jrieken commented Sep 24, 2020 • edited Loading

Siegrift commented Oct 9, 2020 • edited Loading

jrieken commented Jan 7, 2021

koto commented Jan 7, 2021

koto commented Jan 8, 2021

koto commented Jan 12, 2021

jrieken commented Jan 12, 2021

jrieken commented Jan 12, 2021

engelsdamien commented Jan 28, 2021

jrieken commented Feb 2, 2021

engelsdamien commented Feb 2, 2021

jrieken commented Feb 2, 2021

jrieken commented Jun 25, 2021

koto commented Jun 25, 2021 • edited Loading

jrieken commented Jun 25, 2021

annkamsk commented Jul 31, 2020 •

edited

Loading

jrieken commented Sep 24, 2020 •

edited

Loading

Siegrift commented Oct 9, 2020 •

edited

Loading

koto commented Jun 25, 2021 •

edited

Loading