Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Types compatibility: script for identifying violations #105747

Closed
annkamsk opened this issue Aug 31, 2020 · 1 comment · Fixed by #105748
Closed

Trusted Types compatibility: script for identifying violations #105747

annkamsk opened this issue Aug 31, 2020 · 1 comment · Fixed by #105748
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
August 2020

Comments

@annkamsk
Copy link
Contributor

As mentioned in the #103699 thread by @jrieken, there is a need for a tool that would help developers engaged in the VSCode project identify the Trusted Types violations. This can be achieved by adding tsec as a devDependency and an appropriate yarn script.
@annkamsk annkamsk mentioned this issue Aug 31, 2020
Merged
@mjbvz mjbvz assigned jrieken and unassigned mjbvz Aug 31, 2020
@jrieken jrieken added this to the September 2020 milestone Sep 1, 2020
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Sep 1, 2020
@jrieken jrieken modified the milestones: September 2020, August 2020 Sep 1, 2020
jrieken added a commit that referenced this issue Sep 1, 2020
@jrieken
yarn.lock and task for tsec, #105747
45e6a5e
@jrieken
Copy link
Member

jrieken commented Sep 1, 2020 •
edited
Loading

I have also added a task-definition so that tsec errors show in the editor itself. F1 > Run Task > tsec

Screenshot 2020-09-01 at 13 07 22

@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Add script for running tsec annkamsk/vscode
4 participants
@jrieken @mjbvz @annkamsk and others