Angular CLI update for new VS Code JS debugger #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugger for Chrome has been deprecated and the launch.json needs a couple tweaks to use the new build in debugger
connor4312
reviewed
Aug 5, 2021
Angular-CLI/README.md
Outdated
| @@ -39,15 +36,15 @@ Then click on the gear icon to configure a launch.json file, selecting **Chrome* | |||
|
|
|||
|  | |||
|
|
|||
| - Replace content of the generated launch.json with the following three configurations: | |||
| - Replace content of the generated launch.json with the following three configurations (use `pwa-msedge` for MS Edge): | |||
There was a problem hiding this comment.
The change to pwa-msedge/chrome isn't required, see microsoft/vscode-js-debug#1065
There was a problem hiding this comment.
Interesting, I was just changing that based on what VS Code was telling me:
There was a problem hiding this comment.
The Debugger for Chrome is still needed to use type: chrome in the currently-released VS Code versions, but that will no longer be the case in 1.60.0 (which releases to stable early next month, and should arrive in Insiders today)
next version of VS Code will support chrome/msedge without needing pwa-
connor4312
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugger for Chrome has been deprecated and the launch.json needs a couple tweaks to use the new build in debugger. Also threw in setting up Edge as well