Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take ownership of the default node, chrome, extensionHost, and msedge types #1065

Closed
connor4312 opened this issue Aug 3, 2021 · 4 comments
Closed
Assignees
Labels
debt Code quality issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

This month we are (finally) removing the legacy Node debug extensions from being built-in. All old debug extensions will still be accessible in the marketplace, but they (including the Chrome and Edge debuggers) will require the legacy- prefix in the launch "type" to use. The debug.javascript.usePreview setting is going away.

js-debug will take ownership of the default launch types, and will no longer require the pwa- prefix. However, we will continue allowing the "pwa-" prefix in launch.json's and the "redirection" logic will ensure launched sessions are prefixed, to avoid breaking extensions that depend on the type.

@connor4312 connor4312 added feature-request Request for new features or functionality debt Code quality issues verification-found Issue verification failed verification-needed Verification of issue is requested labels Aug 3, 2021
@connor4312 connor4312 added this to the August 2021 milestone Aug 3, 2021
@connor4312 connor4312 self-assigned this Aug 3, 2021
@connor4312 connor4312 removed the verification-found Issue verification failed label Aug 3, 2021
connor4312 added a commit to microsoft/vscode-node-debug2 that referenced this issue Aug 3, 2021
connor4312 added a commit to microsoft/vscode-node-debug that referenced this issue Aug 3, 2021
connor4312 added a commit to microsoft/vscode-chrome-debug that referenced this issue Aug 3, 2021
@bpasero bpasero added the verification-steps-needed Steps to verify are needed for verification label Aug 24, 2021
@bpasero
Copy link
Member

bpasero commented Aug 24, 2021

Steps?

@connor4312
Copy link
Member Author

  1. Create a launch config using each of the listed types
  2. Set trace: true in the config
  3. Verify that the path logged in the Debug Console ends with .json.gz (easiest indicator of the new debugger)
  4. Do the same with types using a pwa- prefix, and verify that it still works

@connor4312 connor4312 removed the verification-steps-needed Steps to verify are needed for verification label Aug 24, 2021
@weinand weinand added on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded labels Aug 25, 2021
@weinand
Copy link

weinand commented Aug 25, 2021

I've verifed:

  • setting debug.javascript.usePreview is no longer known
  • js-debug is available via the debug types: node, extensionHost, chrome, msedge and the corresponding pwa- prefixed types.
  • installing the deprecated node debug extensions on the Marketplace (node-debug and node-debug2) does not interfere with js-debug: the deprecated debug extensions are only available via the legacy- prefix (this includes legacy-node2). I could still debug node.js programs for node.js versions < 8.0.

@liesauer
Copy link

cannot switch back to legacy chrome debugger using legacy-chrome.
it says doesn't support legacy-chrome type.
image

@connor4312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants