Add React Native direct debugger

README.md

@@ -41,6 +41,8 @@ Once app is loaded and ran, [open Developer Menu](https://facebook.github.io/rea
 
 You can debug your app on an Android emulator, Android device or iOS simulator. This extension provides [experimental support](doc/debugging.md#debugging-on-ios-device) for iOS devices.
 
+Since version 0.60.2 [React Native supports Hermes engine for Android applications](https://facebook.github.io/react-native/blog/2019/07/17/hermes). Extension provides experimental support for debugging React Native Android applications with Hermes enabled. Please see [Debugging React Native apps with Hermes enabled](doc/debugging.md#debugging-react-native-apps-with-hermes-enabled) for more details.
+
 More information about debugging using VS Code can be found in this [guide](https://code.visualstudio.com/docs/editor/debugging).
 
 See [Setting up debug environment](doc/debugging.md) for more details.

doc/debugging.md

@@ -66,3 +66,35 @@ For WPF apps use `wpf`, e.g.(WPF debugging available only for react-native-windo
     "platform": "wpf"
 }
 ```
+
+## Debugging React Native apps with Hermes enabled
+
+Hermes is the new JavaScript engine optimized for running React Native apps on Android. It improves app performance and decreases app size.
+
+To enable Hermes for your app please follow [this official instructions](https://facebook.github.io/react-native/docs/hermes/).
+
+Debugging apps with Hermes enabled is currently experimental and don't fully support all the features that are available for stable debugger. Please, see [this issue](https://github.com/microsoft/vscode-react-native/issues/1073) for more details about the implementation progress.
+
+If you use Hermes engine, you are required to choose one of the following configurations:
+ - React Native Direct: Debug Android
+
+```
+{
+    "name": "Debug Android (Hermes)",
+    "cwd": "${workspaceFolder}",
+    "type": "reactnativedirect",
+    "request": "launch",
+    "platform": "android"
+}
+```
+
+ - React Native Direct: Attach to packager
+
+ ```
+{
+    "name": "Attach to packager (Hermes)",
+    "cwd": "${workspaceFolder}",
+    "type": "reactnativedirect",
+    "request": "attach"
+}
+```

package.json

@@ -354,6 +354,174 @@
 						}
 					}
 				}
+			},
+			{
+				"type": "reactnativedirect",
+				"label": "React Native Direct",
+				"program": "./src/debugger/direct/reactNativeDirectDebugEntryPoint.js",
+				"runtime": "node",
+				"enableBreakpointsFor": {
+					"languageIds": [
+						"javascript",
+						"typescript",
+						"javascriptreact",
+						"typescriptreact"
+					]
+				},
+				"configurationSnippets": [
+					{
+						"label": "React Native (Hermes): Debug Android",
+						"description": "%reactNative.snippets.debugAndroidHermes.description%",
+						"body": {
+							"name": "Debug Android (Hermes)",
+							"cwd": "^\"\\${workspaceFolder}\"",
+							"type": "reactnativedirect",
+							"request": "launch",
+							"platform": "android"
+						}
+					},
+					{
+						"label": "React Native (Hermes): Attach to packager",
+						"description": "%reactNative.snippets.attachPackagerHermes.description%",
+						"body": {
+							"name": "Attach to packager (Hermes)",
+							"cwd": "^\"\\${workspaceFolder}\"",
+							"type": "reactnativedirect",
+							"request": "attach"
+						}
+					}
+				],
+				"configurationAttributes": {
+					"attach": {
+						"required": [
+							"cwd"
+						],
+						"properties": {
+							"cwd": {
+								"type": "string",
+								"description": "%reactNative.attach.cwd.description%",
+								"default": "${workspaceFolder}"
+							},
+							"trace": {
+								"type": "string",
+								"enum": [
+									"verbose",
+									"log",
+									"warn",
+									"error",
+									"stop"
+								],
+								"default": "log",
+								"description": "%reactNative.attach.trace.description%"
+							},
+							"address": {
+								"type": "string",
+								"description": "%reactNative.attach.address.description%",
+								"default": "localhost"
+							},
+							"port": {
+								"type": "string",
+								"description": "%reactNative.attach.port.description%",
+								"default": "8081"
+							},
+							"skipFiles": {
+								"type": "array",
+								"description": "%reactNative.attach.skipFiles.description%",
+								"items": {
+									"type": "string"
+								},
+								"default": []
+							}
+						}
+					},
+					"launch": {
+						"required": [
+							"cwd",
+							"platform"
+						],
+						"properties": {
+							"platform": {
+								"type": "string",
+								"enum": [
+									"android"
+								],
+								"description": "%reactNative.launch.platform.description%"
+							},
+							"cwd": {
+								"type": "string",
+								"description": "%reactNative.launch.cwd.description%",
+								"default": "${workspaceFolder}"
+							},
+							"target": {
+								"anyOf": [
+									{
+										"type": "string",
+										"enum": [
+											"device",
+											"simulator"
+										]
+									},
+									{
+										"type": "string"
+									}
+								],
+								"default": "simulator",
+								"description": "%reactNative.launch.target.description%"
+							},
+							"logCatArguments": {
+								"type": "array",
+								"description": "%reactNative.launch.logCatArguments.description%",
+								"default": [
+									"*:S",
+									"ReactNative:V",
+									"ReactNativeJS:V"
+								]
+							},
+							"runArguments": {
+								"type": "array",
+								"description": "%reactNative.launch.runArguments.description%"
+							},
+							"env": {
+								"type": "object",
+								"additionalProperties": {
+									"type": "string"
+								},
+								"description": "%reactNative.launch.env.description%",
+								"default": {}
+							},
+							"envFile": {
+								"type": "string",
+								"description": "%reactNative.launch.envFile.description%",
+								"default": "${workspaceFolder}/.env"
+							},
+							"skipFiles": {
+								"type": "array",
+								"description": "%reactNative.launch.skipFiles.description%",
+								"items": {
+									"type": "string"
+								},
+								"default": []
+							},
+							"trace": {
+								"type": "string",
+								"enum": [
+									"verbose",
+									"log",
+									"warn",
+									"error",
+									"stop"
+								],
+								"default": "log",
+								"description": "%reactNative.launch.trace.description%"
+							},
+							"launchActivity": {
+								"type": "string",
+								"description": "%reactNative.launch.launchActivity.description%",
+								"default": "MainActivity"
+							}
+						}
+					}
+				}
 			}
 		],
 		"configuration": {

package.nls.json

@@ -14,8 +14,10 @@
     "reactNative.command.reloadApp.title":"Reload App",
     "reactNative.command.runInspector.title":"Run Element Inspector",
     "reactNative.snippets.debugAndroid.description":"A new configuration for launching react-native app on android",
+    "reactNative.snippets.debugAndroidHermes.description":"A new configuration for launching react-native Hermes app on android",
     "reactNative.snippets.debugiOS.description":"A new configuration for launching react-native app on iOS",
     "reactNative.snippets.attachPackager.description":"A new configuration for attaching to packager",
+    "reactNative.snippets.attachPackagerHermes.description":"A new configuration for attaching to packager of Android Hermes app",
     "reactNative.snippets.debugExpo.description":"A new configuration for launching Expo app",
     "reactNative.attach.program.description":"[DEPRECATED. USE cwd INSTEAD] The path to launchReactNative.js in the vscode folder",
     "reactNative.attach.cwd.description":"The path to the project root folder",

src/common/extensionHelper.ts

@@ -0,0 +1,10 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for details.
+
+import * as path from "path";
+import * as fs from "fs";
+
+export function getExtensionVersion() {
+    const projectRoot = path.join(__dirname, "..", "..");
+    return JSON.parse(fs.readFileSync(path.join(projectRoot, "package.json"), "utf-8")).version;
+}

src/common/telemetryHelper.ts

@@ -52,6 +52,13 @@ export class TelemetryHelper {
         Telemetry.send(event);
     }
 
+    public static sendDirect(eventName: string, properties?: Telemetry.ITelemetryProperties): void {
+        const event = TelemetryHelper.createTelemetryEvent(eventName, {isDirect: true});
+        if (properties)
+            TelemetryHelper.addTelemetryEventProperties(event, properties);
+        Telemetry.send(event);
+    }
+
     public static sendCommandSuccessTelemetry(commandName: string, commandProperties: ICommandTelemetryProperties, args: string[] = []): void {
         let successEvent: Telemetry.TelemetryEvent = TelemetryHelper.createBasicCommandTelemetry(commandName, args);