Add React Native direct debugger #1088

RedMickey · 2019-08-28T11:53:03Z

Add React Native direct debugger to support debugging of Android Hermes apps. #1073

Telemetry description

Node Debugger telemetry and Direct Debugger telemetry comparison

Node Debugger telemetry events	Direct Debugger telemetry events
- `useProgramProperty`	- removed
- `useCwdProperty`	- removed
- `launch` Consists of 5 steps: initialStep, startPackager, prewarmBundleCache, mobilePlatform.runApp, mobilePlatform.enableJSDebuggingMode. Each step is independent telemetry object that measures its completion time (in form eventname.time) and may contain additional properties such as errors etc.	- `launch` Added the special new launch event to separate the launch of Direct debugger from default app launch. All default telemetry steps are similar to Node Debugger case and all parameters remained the same. added property `isDirect`
- launch.initialStep	- launch.initialStep added property `isDirect`
- launch.checkPlatformCompatibility	- launch.checkPlatformCompatibility added property `isDirect`
- launch.startPackager	- launch.startPackager added property `isDirect`
- launch.prewarmBundleCache	- launch.prewarmBundleCache added property `isDirect`
- AndroidPlatform.runApp	- AndroidPlatform.runApp added property `isDirect`
- launch.mobilePlatform.runApp	- launch.mobilePlatform.runApp added property `isDirect`
- `mobilePlatform.enableJSDebuggingMode` the step for NodeDebugAdapter in `launch` app sequence	- `mobilePlatform.enableDirectDebuggingMode` added the step `mobilePlatform.enableDirectDebuggingMode` in `launch` app sequence instead of `mobilePlatform.enableJSDebuggingMode`
- `attach`	- `attach` added property `isDirect`

doc/debugging.md

README.md

doc/debugging.md

package.json

src/debugger/direct/directDebugAdapter.ts

src/debugger/direct/reactNativeDirectDebugEntryPoint.ts

src/extension/extensionServer.ts

README.md

doc/debugging.md

src/debugger/direct/reactNativeDirectDebugEntryPoint.ts

src/extension/debugConfigurationProvider.ts

package.json

src/debugger/direct/directDebugAdapter.ts

SounD120

Please ensure all newly added telemetry events are sent correctly.

src/debugger/direct/directDebugAdapter.ts

src/common/telemetry.ts

src/debugger/direct/directDebugAdapter.ts

src/extension/extensionServer.ts

…debugger

…dMickey/vscode-react-native into react-native-direct-debugger2

src/common/telemetryHelper.ts

src/extension/extensionServer.ts

dhanvikapila

Please change any string with Hermes that is visible for users to include "experimental" in it.

doc/debugging.md

package.json

src/common/telemetryHelper.ts

src/debugger/direct/directDebugAdapter.ts

package.json

package.nls.json

src/common/extensionHelper.ts

src/debugger/direct/directDebugAdapter.ts

src/debugger/direct/directSessionWrapper.ts

src/extension/launchArgs.ts

src/debugger/direct/directDebugAdapter.ts

src/extension/extensionServer.ts

src/debugger/direct/directDebugAdapter.ts

package.nls.json

No longer relevant

Co-Authored-By: Yuri Skorokhodov <[email protected]>

RedMickey and others added 5 commits August 28, 2019 10:48

add Direct debugger

fdcdf0b

supplement Hermes docs

cee1961

change Hermes docs 2

b7258d7

change debug scenarios' names

cc01499

Merge branch 'master' into react-native-direct-debugger2

0b31d80

SounD120 requested review from SounD120 and ruslan-bikkinin August 28, 2019 12:13

ruslan-bikkinin previously requested changes Aug 28, 2019

View reviewed changes

RedMickey added 2 commits August 28, 2019 16:09

change direct debugger scenarios' parameters

84df93d

fix code according PR comments

33f9ddd

ruslan-bikkinin reviewed Aug 28, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

doc/debugging.md Outdated Show resolved Hide resolved

src/debugger/direct/reactNativeDirectDebugEntryPoint.ts Outdated Show resolved Hide resolved

src/extension/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

change docs and fix code according PR comments

69360fd

ruslan-bikkinin reviewed Aug 29, 2019

View reviewed changes

SounD120 reviewed Aug 29, 2019

View reviewed changes

src/debugger/direct/directDebugAdapter.ts Outdated Show resolved Hide resolved

src/debugger/direct/directDebugAdapter.ts Outdated Show resolved Hide resolved

src/debugger/direct/directDebugAdapter.ts Show resolved Hide resolved

RedMickey and others added 4 commits August 29, 2019 13:46

add desctiption of Hermes debug scenarios

af4d45a

fix comment in code

f511157

fix comment in code2

a3becad

Merge branch 'master' into react-native-direct-debugger2

84798b7

SounD120 reviewed Aug 31, 2019

View reviewed changes

src/common/telemetry.ts Outdated Show resolved Hide resolved

src/debugger/direct/directDebugAdapter.ts Show resolved Hide resolved

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

RedMickey added 3 commits September 2, 2019 10:41

change sendDirect method location and telemetry step name for direct …

79975a1

…debugger

Merge branch 'react-native-direct-debugger2' of https://github.com/Re…

afbea95

…dMickey/vscode-react-native into react-native-direct-debugger2

change log message about Hermes debugging

8605733

SounD120 requested review from ruslan-bikkinin and SounD120 September 2, 2019 13:21

SounD120 marked this pull request as ready for review September 2, 2019 13:24

ruslan-bikkinin reviewed Sep 2, 2019

View reviewed changes

src/common/telemetryHelper.ts Show resolved Hide resolved

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

SounD120 requested a review from dhanvikapila September 2, 2019 14:04

RedMickey added 2 commits September 3, 2019 10:47

Fix code style errors

27617cd

Separate the log message for Hermes in enableDirectDebuggingMode step

09b295e

SounD120 reviewed Sep 3, 2019

View reviewed changes

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

change conditional operator

a2fd6bb

dhanvikapila reviewed Sep 3, 2019

View reviewed changes

RedMickey added 3 commits September 4, 2019 22:02

Rename isDirect flag and change docs

9f22452

Add 'Experemental' word to Hermes debugger name

2eac8e1

Add isDirect flag to all steps of Hermes debugging

679be78

SounD120 reviewed Sep 10, 2019

View reviewed changes

fix code style and little bugs

362c701

SounD120 reviewed Sep 10, 2019

View reviewed changes

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

Change Hermes debugging log message

573c719

SounD120 requested review from ruslan-bikkinin, dhanvikapila and SounD120 September 10, 2019 12:49

dhanvikapila reviewed Sep 19, 2019

View reviewed changes

src/debugger/direct/directDebugAdapter.ts Show resolved Hide resolved

src/debugger/direct/directDebugAdapter.ts Show resolved Hide resolved

src/debugger/direct/directDebugAdapter.ts Show resolved Hide resolved

SounD120 reviewed Sep 26, 2019

View reviewed changes

package.nls.json Outdated Show resolved Hide resolved

SounD120 removed the request for review from ruslan-bikkinin September 26, 2019 09:12

RedMickey and others added 2 commits September 26, 2019 14:05

Little description fix

2061086

Co-Authored-By: Yuri Skorokhodov <[email protected]>

Merge branch 'master' into react-native-direct-debugger2

2c24ac9

SounD120 approved these changes Sep 26, 2019

View reviewed changes

RedMickey merged commit 549baae into microsoft:master Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add React Native direct debugger #1088

Add React Native direct debugger #1088

RedMickey commented Aug 28, 2019 •

edited

Loading

SounD120 left a comment

dhanvikapila left a comment

Add React Native direct debugger #1088

Add React Native direct debugger #1088

Conversation

RedMickey commented Aug 28, 2019 • edited Loading

Telemetry description

Node Debugger telemetry and Direct Debugger telemetry comparison

SounD120 left a comment

Choose a reason for hiding this comment

dhanvikapila left a comment

Choose a reason for hiding this comment

RedMickey commented Aug 28, 2019 •

edited

Loading