Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ds web pack scripts into build/webpack folder #9369

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Move ds web pack scripts into build/webpack folder #9369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad4eb3
Move webpack scripts into one place
DonJayamanne Jan 2, 2020
aa10bfa
More fixes
DonJayamanne Jan 2, 2020
1c55947
Fix scripts
DonJayamanne Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions webpack.config.js → build/webpack/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

const merge = require('webpack-merge');
const datascience = require('./webpack.datascience-ui.config.js');
const extensionDependencies = require('./build/webpack/webpack.extension.dependencies.config.js').default;
const extensionDependencies = require('./webpack.extension.dependencies.config.js').default;

const configurations = [
// history-react
Expand All @@ -26,18 +26,17 @@ const configurations = [
}),
merge(extensionDependencies, {
mode: 'production',
devtool: 'source-map',
devtool: 'source-map'
})
];

// Dirty temporary hack.
// If the environment variable BUNDLE_INDEX is defined, then return just one item in the array.
// Refer issue for further details (https://github.com/microsoft/vscode-python/issues/9055)
if (process.env.BUNDLE_INDEX){
if (process.env.BUNDLE_INDEX) {
console.info(`Using Optimized Build, Bundle Index ${process.env.BUNDLE_INDEX}`);
module.exports = [configurations[parseInt(process.env.BUNDLE_INDEX, 10)]];
} else {
console.info('Not using Optimized Build');
module.exports = configurations;
}

Loading