Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ds web pack scripts into build/webpack folder #9369

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jan 2, 2020

Part of #9055
(next PR is #9373 where #9055 is resolved)

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #9369 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9369      +/-   ##
==========================================
- Coverage   60.33%   59.21%   -1.12%     
==========================================
  Files         545      550       +5     
  Lines       28668    30046    +1378     
  Branches     4345     4683     +338     
==========================================
+ Hits        17296    17792     +496     
- Misses      10436    11285     +849     
- Partials      936      969      +33
Impacted Files Coverage Δ
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 7.05% <0%> (-3.43%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 17.31% <0%> (-1.69%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 3.73% <0%> (-1.1%) ⬇️
src/client/datascience/serviceRegistry.ts 0% <0%> (ø) ⬆️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
...ient/datascience/jupyter/kernels/kernelSwitcher.ts 83.82% <0%> (ø)
src/client/datascience/commands/commandRegistry.ts 28.15% <0%> (ø)
src/client/datascience/commands/kernelSwitcher.ts 91.66% <0%> (ø)
src/client/datascience/commands/serverSelector.ts 81.81% <0%> (ø)
src/client/datascience/jupyter/serverSelector.ts 91.83% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9bc97...1c55947. Read the comment docs.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne reopened this Jan 3, 2020
@DonJayamanne DonJayamanne merged commit 0911d4d into microsoft:master Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
@DonJayamanne DonJayamanne deleted the moveDSWebPackScripts branch April 30, 2020 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants