Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipelines into stages #7430

Merged
merged 12 commits into from
Sep 17, 2019
Merged

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Sep 17, 2019

Refactor pipelines into stages, in preparation for the UI Tests.
Broke UI Tests PR into multiple. First PR would be to refactor the pipeline into stages (without any UI Test specific changes).

Created PR upon @rchiodo @IanMatthewHuff request when the UI Tests PR (#6717) was reviewed.

Benefits of refactor:

  • Single template file with global variables (python, node, npm versions, etc). All in one place.
  • Template file to initialze jobs (install python, node)
  • Template file to compile, build, etc
  • I.e. more moduralized for easier maintenance with benefit of reuse of templates.
  • Easily visible what stage fails, build, test or reporting phase.
    • Tomorrow linting, checking format of files etc can be added into the build stage.

See below:

Screenshot 2019-09-17 at 10 46 58

Detailed view:
Screenshot 2019-09-17 at 15 39 38
Screenshot 2019-09-17 at 16 34 06

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #7430 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7430      +/-   ##
==========================================
+ Coverage   58.22%   58.56%   +0.34%     
==========================================
  Files         492      494       +2     
  Lines       21747    21783      +36     
  Branches     3481     3489       +8     
==========================================
+ Hits        12662    12758      +96     
+ Misses       8298     8236      -62     
- Partials      787      789       +2
Impacted Files Coverage Δ
src/client/common/crypto.ts 73.33% <0%> (-8.49%) ⬇️
...rc/client/common/process/pythonExecutionFactory.ts 91.66% <0%> (-5.11%) ⬇️
src/client/interpreter/helpers.ts 44.77% <0%> (-1.38%) ⬇️
...reter/locators/services/windowsStoreInterpreter.ts 100% <0%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/interpreter/locators/types.ts 100% <0%> (ø) ⬆️
...client/common/process/windowsStorePythonProcess.ts 40% <0%> (ø)
...interpreter/locators/services/interpreterFilter.ts 60% <0%> (ø)
src/client/common/experiments.ts 97.19% <0%> (+0.08%) ⬆️
...client/activation/languageServer/languageServer.ts 92.06% <0%> (+0.53%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f2163...9057018. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the fixPipelines branch 2 times, most recently from 30a62b9 to 25f4d1c Compare September 17, 2019 11:35
@DonJayamanne DonJayamanne marked this pull request as ready for review September 17, 2019 11:48
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit c9dc8fb into microsoft:master Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
@DonJayamanne DonJayamanne deleted the fixPipelines branch September 29, 2019 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants