Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - UI Tests in nodejs #6717

Closed
wants to merge 29 commits into from
Closed

Conversation

DonJayamanne
Copy link

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne force-pushed the puppeteer branch 4 times, most recently from 8c8b00c to ca52743 Compare August 2, 2019 18:25
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Aug 2, 2019
@DonJayamanne DonJayamanne changed the title WIP WIP - UI Tests in nodejs Aug 3, 2019
@DonJayamanne DonJayamanne force-pushed the puppeteer branch 10 times, most recently from d1d619b to e62e7fc Compare August 14, 2019 06:03
@DonJayamanne DonJayamanne force-pushed the puppeteer branch 4 times, most recently from f64a4da to 7f7454e Compare August 16, 2019 20:18
@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #6717 into master will increase coverage by <.01%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
+ Coverage   58.56%   58.56%   +<.01%     
==========================================
  Files         494      494              
  Lines       21785    21799      +14     
  Branches     3489     3493       +4     
==========================================
+ Hits        12758    12767       +9     
- Misses       8238     8240       +2     
- Partials      789      792       +3
Impacted Files Coverage Δ
src/client/testing/display/main.ts 81.1% <100%> (ø) ⬆️
src/client/common/constants.ts 100% <100%> (ø) ⬆️
src/client/common/process/logger.ts 86.95% <50%> (-13.05%) ⬇️
.../client/activation/languageServer/outputChannel.ts 88.23% <81.81%> (-11.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6378018...713fde0. Read the comment docs.

@DonJayamanne DonJayamanne deleted the puppeteer branch September 29, 2019 20:58
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants